Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2.6.26-rc2] ASoC: Fix wrong enum count for jack_function in N810 machine driver
@ 2008-05-13 12:42 Jarkko Nikula
  2008-05-13 13:23 ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Nikula @ 2008-05-13 12:42 UTC (permalink / raw)
  To: alsa-devel; +Cc: Jarkko Nikula

Fix this typo and avoid similar errors by using ARRAY_SIZE macro.

Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
---
 sound/soc/omap/n810.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/omap/n810.c b/sound/soc/omap/n810.c
index 83b1eb4..6533563 100644
--- a/sound/soc/omap/n810.c
+++ b/sound/soc/omap/n810.c
@@ -188,8 +188,8 @@ static const char *audio_map[][3] = {
 static const char *spk_function[] = {"Off", "On"};
 static const char *jack_function[] = {"Off", "Headphone"};
 static const struct soc_enum n810_enum[] = {
-	SOC_ENUM_SINGLE_EXT(2, spk_function),
-	SOC_ENUM_SINGLE_EXT(3, jack_function),
+	SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(spk_function), spk_function),
+	SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(jack_function), jack_function),
 };
 
 static const struct snd_kcontrol_new aic33_n810_controls[] = {
-- 
1.5.5.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 2.6.26-rc2] ASoC: Fix wrong enum count for jack_function in N810 machine driver
  2008-05-13 12:42 [PATCH 2.6.26-rc2] ASoC: Fix wrong enum count for jack_function in N810 machine driver Jarkko Nikula
@ 2008-05-13 13:23 ` Mark Brown
  2008-05-13 13:32   ` Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2008-05-13 13:23 UTC (permalink / raw)
  To: Jarkko Nikula; +Cc: alsa-devel

On Tue, May 13, 2008 at 03:42:04PM +0300, Jarkko Nikula wrote:

> Fix this typo and avoid similar errors by using ARRAY_SIZE macro.

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

and queued for Takashi if he doesn't pick it up directly first.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2.6.26-rc2] ASoC: Fix wrong enum count for jack_function in N810 machine driver
  2008-05-13 13:23 ` Mark Brown
@ 2008-05-13 13:32   ` Takashi Iwai
  0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2008-05-13 13:32 UTC (permalink / raw)
  To: Mark Brown; +Cc: alsa-devel, Jarkko Nikula

At Tue, 13 May 2008 14:23:53 +0100,
Mark Brown wrote:
> 
> On Tue, May 13, 2008 at 03:42:04PM +0300, Jarkko Nikula wrote:
> 
> > Fix this typo and avoid similar errors by using ARRAY_SIZE macro.
> 
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> 
> and queued for Takashi if he doesn't pick it up directly first.

I did :)  Will be for the next push round.


Thanks anyway.

Takashi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-05-13 13:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-13 12:42 [PATCH 2.6.26-rc2] ASoC: Fix wrong enum count for jack_function in N810 machine driver Jarkko Nikula
2008-05-13 13:23 ` Mark Brown
2008-05-13 13:32   ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox