Re: [PATCH]snd-usb-usx2y 0.8.0 against alsa-kernel cvshead: OHCI doesn't crash anymore

[Takashi Iwai <tiwai@suse.de>]

At Thu, 30 Sep 2004 20:46:29 +0200,
Karsten Wiese wrote:
> 
> Summary: Prevents crashes when communicating over ohci usb-hcds.
> 
> Work on this started, when rumors spread that ohci equipped machines would 
> crash.
> This was due to me missing two facts:
> 1) Ohci has a bigger usb frame number wrap around.
> 2) It only supports URB_ISO_ASAP when submitting iso urbs.
> Fixed now.
> Usb-traffic for playback starts now in the prepare callback, like it 
> previously only did for capture.
> As a side effect code became simpler and smaller.
> 
> Signed-off-by: Karsten Wiese <annabellesgarden@yahoo.de>

Thanks for the patch.

What is the purpose of the replacement with USX2Y_STATIC?

One thing I'm not sure is that the possible race of usX2Y_urbs_start()
and usX2Y_subs_startup_finish().  Better to use complete handler?


Takashi


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl