Re: [PATCH]snd-usb-usx2y 0.8.0 against alsa-kernel cvshead: OHCI doesn't crash anymore

[Takashi Iwai <tiwai@suse.de>]

At Fri, 1 Oct 2004 18:28:32 +0200,
Karsten Wiese wrote:
> 
> Am Freitag 01 Oktober 2004 15:50 schrieb Takashi Iwai:
> >
> > What is the purpose of the replacement with USX2Y_STATIC?
> >
> Its for easier appliance of the patch, I sent a little later yesterday 
> 22:01:50:
> "[Alsa-devel] [PATCH]hwdep addon for raw usb mmap from userspace against 
> snd-usb-usx2y 0.8.0 in alsa-kernel tree"
> The addon needs the functions with the USX2Y_STATIC.
> So the addon patch only needs to change
> 	#define USX2Y_STATIC static
> to
> 	#define USX2Y_STATIC
> .

Well, this won't make the patch applicance easier at all.

If the second patch weren't accepted, it's because the patch does
really bad indeed (e.g. written too dirty or conceptually wrong).
Then USX2Y_STATIC in the first patch would be useless, anyway.

If the second patch were accepted, you can include static -> extern
conversion in this patch without problems.  Thus, having USX2Y_STATIC
in the first patch isn't necessary, too.

In sort: You shouldn't sacrifice the right patch just because of
others :)


Takashi


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl