From: Takashi Iwai <tiwai@suse.de>
To: Tim Sheridan <tim.sheridan@imgtec.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
alsa-devel@alsa-project.org,
pierre-louis.bossart@linux.intel.com
Subject: Re: [PATCH] ALSA: compress: Add DSP private metadata interface
Date: Tue, 23 Feb 2016 10:31:18 +0100 [thread overview]
Message-ID: <s5h8u2b22op.wl-tiwai@suse.de> (raw)
In-Reply-To: <1456163671-40987-1-git-send-email-tim.sheridan@imgtec.com>
Add Vinod to Cc.
On Mon, 22 Feb 2016 18:54:31 +0100,
Tim Sheridan wrote:
>
> Provides an area to communicate with a DSP to implement support for
> weird and wonderful features of DSP hardware that aren't supported in
> the compress offload API.
>
> Signed-off-by: Tim Sheridan <tim.sheridan@imgtec.com>
Don't you have the code actually implement this ioctl?
Or, is there anything I miss?
thanks,
Takashi
> ---
> include/uapi/sound/compress_offload.h | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/include/uapi/sound/compress_offload.h b/include/uapi/sound/compress_offload.h
> index e00d8cb..65ac445 100644
> --- a/include/uapi/sound/compress_offload.h
> +++ b/include/uapi/sound/compress_offload.h
> @@ -30,7 +30,7 @@
> #include <sound/compress_params.h>
>
>
> -#define SNDRV_COMPRESS_VERSION SNDRV_PROTOCOL_VERSION(0, 1, 2)
> +#define SNDRV_COMPRESS_VERSION SNDRV_PROTOCOL_VERSION(0, 1, 3)
> /**
> * struct snd_compressed_buffer - compressed buffer
> * @fragment_size: size of buffer fragment in bytes
> @@ -150,6 +150,8 @@ struct snd_compr_metadata {
> * SNDRV_COMPRESS_SET_PARAMS: Set codec and stream parameters
> * Note: only codec params can be changed runtime and stream params cant be
> * SNDRV_COMPRESS_GET_PARAMS: Query codec params
> + * SNDRV_COMPRESS_SET_DSP_PRIV: Set private DSP metadata
> + * SNDRV_COMPRESS_GET_DSP_PRIV: Get private DSP metadata
> * SNDRV_COMPRESS_TSTAMP: get the current timestamp value
> * SNDRV_COMPRESS_AVAIL: get the current buffer avail value.
> * This also queries the tstamp properties
> @@ -171,6 +173,8 @@ struct snd_compr_metadata {
> struct snd_compr_metadata)
> #define SNDRV_COMPRESS_GET_METADATA _IOWR('C', 0x15,\
> struct snd_compr_metadata)
> +#define SNDRV_COMPRESS_SET_DSP_PRIV _IOW('C', 0x16, struct snd_compr_metadata)
> +#define SNDRV_COMPRESS_GET_DSP_PRIV _IOWR('C', 0x17, struct snd_compr_metadata)
> #define SNDRV_COMPRESS_TSTAMP _IOR('C', 0x20, struct snd_compr_tstamp)
> #define SNDRV_COMPRESS_AVAIL _IOR('C', 0x21, struct snd_compr_avail)
> #define SNDRV_COMPRESS_PAUSE _IO('C', 0x30)
> --
> 1.7.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
next prev parent reply other threads:[~2016-02-23 9:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 17:54 [PATCH] ALSA: compress: Add DSP private metadata interface Tim Sheridan
2016-02-23 9:31 ` Takashi Iwai [this message]
2016-02-23 9:42 ` Vinod Koul
2016-02-23 12:47 ` Tim Sheridan
2016-02-23 14:39 ` Pierre-Louis Bossart
2016-02-23 15:40 ` Tim Sheridan
2016-02-23 16:07 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8u2b22op.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tim.sheridan@imgtec.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox