* Enable more HP machine to enable mute led
@ 2014-02-21 8:38 Kailang
2014-02-21 11:05 ` Takashi Iwai
0 siblings, 1 reply; 7+ messages in thread
From: Kailang @ 2014-02-21 8:38 UTC (permalink / raw)
To: Kailang, Takashi Iwai; +Cc: alsa-devel
[-- Attachment #1: Type: text/plain, Size: 122 bytes --]
Hi Takashi,
HP want to enable mute led functions for more machine.
I created patch as attach patch.
Thanks.
BR,
Kailang
[-- Attachment #2: 0000-enable-hp-mute-led.patch --]
[-- Type: application/octet-stream, Size: 4280 bytes --]
>From a0bfe9e3e2c993fab0aa395cd098046e4a4d6db6 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Fri, 21 Feb 2014 16:23:35 +0800
Subject: [PATCH] ALSA: hda/realtek - Add more entry for enable HP mute led
More HP machine need mute led support.
Signed-off-by: Kailang Yang <kailang@realtek.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 0d80c7f..5615e17 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4320,6 +4320,53 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x1973, "HP Pavilion", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x1983, "HP Pavilion", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x218b, "HP", ALC269_FIXUP_LIMIT_INT_MIC_BOOST_MUTE_LED),
+ /* ALC282 */
+ SND_PCI_QUIRK(0x103c, 0x220f, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2213, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2266, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2267, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2268, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2269, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x226a, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x226b, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x227a, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x227b, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x229e, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22a0, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22b2, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22b7, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22bf, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22c0, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22c1, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22c2, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22cd, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22ce, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22cf, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22d0, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ /* ALC290 */
+ SND_PCI_QUIRK(0x103c, 0x2260, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2261, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2262, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2263, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2264, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2265, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x227d, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x227e, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x227f, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2280, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2281, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2282, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2289, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x228a, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x228b, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x228c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x228e, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22c5, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22c6, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22c7, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22c8, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22c3, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x22c4, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK_VENDOR(0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300),
SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread* Enable more HP machine to enable mute led
@ 2014-06-13 9:27 Kailang
2014-06-13 9:41 ` Takashi Iwai
0 siblings, 1 reply; 7+ messages in thread
From: Kailang @ 2014-06-13 9:27 UTC (permalink / raw)
To: Kailang, Takashi Iwai; +Cc: alsa-devel
[-- Attachment #1: Type: text/plain, Size: 91 bytes --]
Hi Takashi,
Add more HP machine to support mute led functions.
Thanks.
BR,
Kailang
[-- Attachment #2: 0000-add-mute-led-for-hp.patch --]
[-- Type: application/octet-stream, Size: 3058 bytes --]
>From f06f78fc2fd45c004ab512b77b4e1945bb52ffda Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Fri, 13 Jun 2014 17:16:31 +0800
Subject: [PATCH] ALSA: hda/realtek - Add more entry for enable HP mute led
More HP machine need mute led support.
Signed-off-by: Kailang Yang <kailang@realtek.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 9c095fa..874647c 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4774,14 +4774,24 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x1983, "HP Pavilion", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x218b, "HP", ALC269_FIXUP_LIMIT_INT_MIC_BOOST_MUTE_LED),
/* ALC282 */
+ SND_PCI_QUIRK(0x103c, 0x220d, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x220e, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x220f, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2210, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2211, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2212, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x2213, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2214, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x2266, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x2267, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x2268, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x2269, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x226a, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x226b, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x226c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x226d, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x226e, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x226f, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x227a, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x227b, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x229e, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
@@ -4821,6 +4831,10 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x22c8, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x22c3, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x22c4, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2334, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2335, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2336, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x2337, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK_VENDOR(0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300),
SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: Enable more HP machine to enable mute led
2014-06-13 9:27 Kailang
@ 2014-06-13 9:41 ` Takashi Iwai
2014-06-13 9:56 ` Kailang
2014-06-18 3:49 ` Kailang
0 siblings, 2 replies; 7+ messages in thread
From: Takashi Iwai @ 2014-06-13 9:41 UTC (permalink / raw)
To: Kailang; +Cc: alsa-devel
At Fri, 13 Jun 2014 17:27:31 +0800,
Kailang wrote:
>
> Hi Takashi,
>
> Add more HP machine to support mute led functions.
Applied this now as is. But, the table looks bigger and bigger, which
I don't like any more.
So, all these devices have no indication of mute LED in any DMI or
whatever entries? In the past, most of HP machines had a DMI string
showing the mute LED capability.
thanks,
Takashi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Enable more HP machine to enable mute led
2014-06-13 9:41 ` Takashi Iwai
@ 2014-06-13 9:56 ` Kailang
2014-06-18 3:49 ` Kailang
1 sibling, 0 replies; 7+ messages in thread
From: Kailang @ 2014-06-13 9:56 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
> At Fri, 13 Jun 2014 17:27:31 +0800,
> Kailang wrote:
>>
>> Hi Takashi,
>>
>> Add more HP machine to support mute led functions.
>
> Applied this now as is. But, the table looks bigger and bigger, which
> I don't like any more.
>
> So, all these devices have no indication of mute LED in any DMI or
> whatever entries? In the past, most of HP machines had a DMI string
> showing the mute LED capability.
>
I will trace this.
But as i know, there are no DMI entries for realtek case.
I don't like to add this, too. ^^
Thanks a lot.
>
> thanks,
>
> Takashi
>
> ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Enable more HP machine to enable mute led
2014-06-13 9:41 ` Takashi Iwai
2014-06-13 9:56 ` Kailang
@ 2014-06-18 3:49 ` Kailang
2014-06-18 10:14 ` Takashi Iwai
1 sibling, 1 reply; 7+ messages in thread
From: Kailang @ 2014-06-18 3:49 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
> At Fri, 13 Jun 2014 17:27:31 +0800,
> Kailang wrote:
>>
>> Hi Takashi,
>>
>> Add more HP machine to support mute led functions.
>
> Applied this now as is. But, the table looks bigger and bigger, which
> I don't like any more.
>
> So, all these devices have no indication of mute LED in any DMI or
> whatever entries? In the past, most of HP machines had a DMI string
> showing the mute LED capability.
>
HP says that was support for IDT only.
If we want to use this string, we need to discuss with their BIOS manager.
We will try to go this feature.
HP has new platform that had speaker mute led and capture mute led.
HP_MUTE_LED_P_G => DMI string was not enough field for two leds.
Do you have any idea for dmi string?
HP_MUTE_LED_P_G_G => last G for second led for capture mute led
>
> thanks,
>
> Takashi
>
> ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Enable more HP machine to enable mute led
2014-06-18 3:49 ` Kailang
@ 2014-06-18 10:14 ` Takashi Iwai
0 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2014-06-18 10:14 UTC (permalink / raw)
To: Kailang; +Cc: alsa-devel
At Wed, 18 Jun 2014 11:49:40 +0800,
Kailang wrote:
>
> > At Fri, 13 Jun 2014 17:27:31 +0800,
> > Kailang wrote:
> >>
> >> Hi Takashi,
> >>
> >> Add more HP machine to support mute led functions.
> >
> > Applied this now as is. But, the table looks bigger and bigger, which
> > I don't like any more.
> >
> > So, all these devices have no indication of mute LED in any DMI or
> > whatever entries? In the past, most of HP machines had a DMI string
> > showing the mute LED capability.
> >
>
> HP says that was support for IDT only.
> If we want to use this string, we need to discuss with their BIOS manager.
> We will try to go this feature.
>
> HP has new platform that had speaker mute led and capture mute led.
> HP_MUTE_LED_P_G => DMI string was not enough field for two leds.
> Do you have any idea for dmi string?
>
> HP_MUTE_LED_P_G_G => last G for second led for capture mute led
This would work. If the mic LED might have a different polarity, it
can be P_G_P_G, too.
thanks,
Takashi
>
> >
> > thanks,
> >
> > Takashi
> >
> > ------Please consider the environment before printing this e-mail.
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-06-18 10:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-21 8:38 Enable more HP machine to enable mute led Kailang
2014-02-21 11:05 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2014-06-13 9:27 Kailang
2014-06-13 9:41 ` Takashi Iwai
2014-06-13 9:56 ` Kailang
2014-06-18 3:49 ` Kailang
2014-06-18 10:14 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox