From: Takashi Iwai <tiwai@suse.de>
To: Hui Wang <hui.wang@canonical.com>
Cc: alsa-devel@alsa-project.org, david.henningsson@canonical.com,
stable@vger.kernel.org, gerald.yang@canonical.com
Subject: Re: [PATCH] ALSA: hda - Enable front audio jacks on one HP desktop model
Date: Thu, 20 Feb 2014 08:17:19 +0100 [thread overview]
Message-ID: <s5ha9dmxngg.wl%tiwai@suse.de> (raw)
In-Reply-To: <1392868041-21319-1-git-send-email-hui.wang@canonical.com>
At Thu, 20 Feb 2014 11:47:21 +0800,
Hui Wang wrote:
>
> The front headphone and mic jackes on a HP desktop model (Vendor Id:
> 0x111d76c7 Subsystem Id: 0x103c2b17) can not work, the codec on this
> machine has 8 physical ports, 6 of them are routed to rear jackes
> and all of them work very well, while the remaining 2 ports are
> routed to front headphone and mic jackes, but the corresponding
> pin complex node are not defined correctly.
>
> After apply this fix, the front audio jackes can work very well.
>
> BugLink: https://bugs.launchpad.net/bugs/1282369
> Cc: David Henningsson <david.henningsson@canonical.com>
> Tested-by: Gerald Yang <gerald.yang@canonical.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
Thanks, I applied with the additional fix below:
> ---
> sound/pci/hda/patch_sigmatel.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index 7311bad..d75f90a 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -83,7 +83,8 @@ enum {
> STAC_DELL_M6_BOTH,
> STAC_DELL_EQ,
> STAC_ALIENWARE_M17X,
> - STAC_92HD73XX_MODELS
> + STAC_92HD73XX_MODELS,
> + STAC_92HD89XX_HP_FRONT_JACK
XXX_MODELS indicate number of enum items (although they aren't
referred any longer in the code), so you need to insert the new item
before it.
Takashi
next prev parent reply other threads:[~2014-02-20 7:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 3:47 [PATCH] ALSA: hda - Enable front audio jacks on one HP desktop model Hui Wang
2014-02-20 7:17 ` Takashi Iwai [this message]
2014-02-20 7:47 ` Hui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ha9dmxngg.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
--cc=gerald.yang@canonical.com \
--cc=hui.wang@canonical.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox