[alsa-devel] [PATCH] ALSA: bebob: Fix prototype of helper function to return negative value

[alsa-devel] [PATCH] ALSA: bebob: Fix prototype of helper function to return negative value

[Takashi Sakamoto]

A helper function of ALSA bebob driver returns negative value in a
function which has a prototype to return unsigned value.

This commit fixes it by changing the prototype.

Fixes: eb7b3a056cd8 ("ALSA: bebob: Add commands and connections/streams management"
Cc: <stable@vger.kernel.org> # v3.16+
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/firewire/bebob/bebob_stream.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/firewire/bebob/bebob_stream.c b/sound/firewire/bebob/bebob_stream.c
index 7ac0d9f495c4..f7f0db5aa811 100644
--- a/sound/firewire/bebob/bebob_stream.c
+++ b/sound/firewire/bebob/bebob_stream.c
@@ -252,8 +252,7 @@ int snd_bebob_stream_get_clock_src(struct snd_bebob *bebob,
 	return err;
 }
 
-static unsigned int
-map_data_channels(struct snd_bebob *bebob, struct amdtp_stream *s)
+static int map_data_channels(struct snd_bebob *bebob, struct amdtp_stream *s)
 {
 	unsigned int sec, sections, ch, channels;
 	unsigned int pcm, midi, location;
-- 
2.20.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [PATCH] ALSA: bebob: Fix prototype of helper function to return negative value

[Takashi Iwai]

On Sat, 26 Oct 2019 05:06:20 +0200,
Takashi Sakamoto wrote:
> 
> A helper function of ALSA bebob driver returns negative value in a
> function which has a prototype to return unsigned value.
> 
> This commit fixes it by changing the prototype.
> 
> Fixes: eb7b3a056cd8 ("ALSA: bebob: Add commands and connections/streams management"
> Cc: <stable@vger.kernel.org> # v3.16+
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Applied, thanks.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel