From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de
Subject: Re: [PATCH] ALSA: firewire-lib: use 8 byte header for IR context to get isochronous cycle
Date: Mon, 18 Mar 2019 14:52:14 +0100 [thread overview]
Message-ID: <s5hbm28ffxt.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190317112506.20243-1-o-takashi@sakamocchi.jp>
On Sun, 17 Mar 2019 12:25:06 +0100,
Takashi Sakamoto wrote:
>
> In kernel API of Linux FireWire subsystem, handlers of isochronous
> receive (IR) context can get context headers as an argument of
> callback. When 4 byte header is used, the context header includes
> isochronous packet header for each packet. When 8 byte header is
> used, it includes isochronous cycle as well.
>
> ALSA IEC 61883-1/6 engine uses 4 byte header, and computes isochronous
> cycle from the cycle of interrupt. The usage of 8 byte header can
> obsolete the computation.
>
> Furthermore, this change works well for a case that a series of
> packet in one interrupt includes skipped isochronous cycle,
>
> This commit uses 8 byte header to handle isochronous cycle.
>
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Applied to for-next branch now. Thanks.
Takashi
prev parent reply other threads:[~2019-03-18 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 11:25 [PATCH] ALSA: firewire-lib: use 8 byte header for IR context to get isochronous cycle Takashi Sakamoto
2019-03-18 13:52 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hbm28ffxt.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=o-takashi@sakamocchi.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox