From: Takashi Iwai <tiwai@suse.de>
To: Ruslan Bilovol <ruslan.bilovol@gmail.com>
Cc: Jorge <jorge.sanjuan@codethink.co.uk>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [alsa-devel] [PATCH 1/4] ALSA: usb: stream: refactor audio interface parsing
Date: Thu, 19 Apr 2018 11:55:37 +0200 [thread overview]
Message-ID: <s5hbmefzfja.wl-tiwai@suse.de> (raw)
In-Reply-To: <1523658266-2259-2-git-send-email-ruslan.bilovol@gmail.com>
On Sat, 14 Apr 2018 00:24:23 +0200,
Ruslan Bilovol wrote:
>
> Offload snd_usb_parse_audio_interface() function which
> became quite long after adding UAC3 spec support.
>
> Move class-specific parts to separate functions
> which now produce audioformat structure that is
> ready to be fed to snd_usb_add_audio_stream().
>
> This also broke Blue Microphones workaround (which
> relies on audioformat decoded from previous altsetting)
> into two parts: prepare quirk flag analyzing previous
> altsetting then use it with current altsetting.
>
> Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
Could you try to split this patch to two parts: one is a simple
refactoring to move the code to snd_usb_get_audioformat_uac12(), and
another to add snd_usb_get_audioformat_uac3().
In this way, we can see a problem more clearly if it's in the
refactoring part.
thanks,
Takashi
next prev parent reply other threads:[~2018-04-19 9:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 22:24 [PATCH 0/4] USB Audio Device Class 3.0 BADD profiles support Ruslan Bilovol
2018-04-13 22:24 ` [PATCH 1/4] ALSA: usb: stream: refactor audio interface parsing Ruslan Bilovol
2018-04-19 9:55 ` Takashi Iwai [this message]
2018-04-23 19:48 ` Ruslan Bilovol
2018-04-13 22:24 ` [PATCH 2/4] include: usb: audio-v3: add BADD-specific values Ruslan Bilovol
2018-04-13 22:24 ` [PATCH 3/4] ALSA: usb: Only get AudioControl header for UAC1 class Ruslan Bilovol
2018-04-13 22:24 ` [PATCH 4/4] ALSA: usb: add UAC3 BADD profiles support Ruslan Bilovol
2018-04-14 17:55 ` Jorge Sanjuan
2018-04-18 0:41 ` Ruslan Bilovol
2018-04-16 9:05 ` kbuild test robot, Dan Carpenter
2018-04-19 9:42 ` [alsa-devel] " Andrew Chant
2018-04-23 19:47 ` Ruslan Bilovol
2018-04-19 10:19 ` [alsa-devel] " Takashi Iwai
2018-04-24 7:51 ` Ruslan Bilovol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hbmefzfja.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=jorge.sanjuan@codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=ruslan.bilovol@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox