Re: [PATCH] ALSA: hda - Add digital BEEP generator support for Realtek codecs.

[Takashi Iwai <tiwai@suse.de>]

At Tue, 3 Feb 2009 23:28:51 +0900,
Kusanagi Kouichi wrote:
> 
> Sorry for the late reply.
> 
> On Mon, Nov 17, 2008 at 17:53:34PM +0100, Takashi Iwai wrote:
> > Thanks for the patch.  Do these beep widgets have the mute amp bits?
> > If not, we'd likely need to add mute switches as well (otherwise it
> > gets too annoying) controlling on software.  Check patch_sigmatel.c in
> > the latest master branch or topic/fix/hda branch of sound git tree:
> >     git://git.kernel.org/pub/scm/linux/kernel/tiwai/sound-2.6.git
> 
> Every codec can mute beep.

Then it's fine.

> > Another concern is that I don't want to add the digital beep control
> > unconditionally.  On many devices, the beep is implemented in the old
> > good analog way.  We'd need to add the check of analog/digital beep in
> > a new spec field and in the preset table not to duplicate beep
> > controls on these.
> 
> I don't think such a check is needed.  I presume that analog beep in
> is disabled while digital beep generetor is being used.
> Furthermore, keyboard bell rings only one device even if both
> HDA Digital PCBeep and PC Speaker have been registered.

However it's just annoying to have multiple controls for the very same
purpose.  If the digital beep works more reliably overall, let's get
rid of all existing analog beep stuff.  Having both makes no sense.

(Well, I don't remember exactly your patch so I suppose your patch
 doesn't remove the analog beep stuff...  Anyway reposting the patch
 and checking it's still applicable to the latest driver code would be
 helpful :)


thanks,

Takashi