Re: [PATCH] ALSA: hda - Add digital BEEP generator support for Realtek codecs.

[Takashi Iwai <tiwai@suse.de>]

At Sat, 07 Feb 2009 12:54:25 +0100,
I wrote:
> 
> At Sat, 7 Feb 2009 19:40:52 +0900,
> Kusanagi Kouichi wrote:
> > 
> > On Fri, Feb 06, 2009 at 05:25:13PM +0100, Takashi Iwai wrote:
> > > At Wed, 04 Feb 2009 15:44:12 +0100,
> > > I wrote:
> > > > 
> > > > At Wed, 4 Feb 2009 23:20:12 +0900,
> > > > Kusanagi Kouichi wrote:
> > > > > 
> > > > > On Wed, Feb 04, 2009 at 12:17:14PM +0100, Takashi Iwai wrote:
> > > > > > Fair enough.
> > > > > > 
> > > > > > Though, there is still one problem -- not all models enabled the
> > > > > > analog beep path.  So, the next step is to create beep controls in all
> > > > > > possible situations.
> > > > > 
> > > > > I'll try later.
> > > > 
> > > > This can be a separate (additional) patch.  Let's get the first patch
> > > > into the main tree so that one can work on further issues.
> > > 
> > > ... and now fixed on sound git tree.
> > 
> > Some models for alc268 still seems to lack a beep control.
> > Is it OK to add a beep control unconditionally?
> 
> The question is whether it works.
> In your previous patch, patch_alc268() is untouched and has no
> digital beep hook yet.
> 
> I'll check a machine with ALC268 later.

As it seems working, I fixed the issue on sound git tree now.


Takashi