From: Takashi Iwai <tiwai@suse.de>
To: "buzzbuzz2@hotmail.com" <buzzbuzz2@hotmail.com>
Cc: ALSA development <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] Add framework for better audigy sound card capabilities selection.
Date: Mon, 21 Mar 2005 20:47:43 +0100 [thread overview]
Message-ID: <s5hbr9c4w80.wl@alsa2.suse.de> (raw)
In-Reply-To: <423B345F.3000901@hotmail.com>
Hi,
the idea looks nice, but...
At Fri, 18 Mar 2005 20:04:47 +0000,
buzzbuzz2@hotmail.com wrote:
>
> Index: alsa-driver/alsa-kernel/pci/emu10k1/emu10k1_main.c
> ===================================================================
> RCS file: /cvsroot/alsa/alsa-kernel/pci/emu10k1/emu10k1_main.c,v
> retrieving revision 1.44
> diff -u -r1.44 emu10k1_main.c
> --- alsa-driver/alsa-kernel/pci/emu10k1/emu10k1_main.c 13 Mar 2005 12:17:08 -0000 1.44
> +++ alsa-driver/alsa-kernel/pci/emu10k1/emu10k1_main.c 18 Mar 2005 19:55:33 -0000
> @@ -611,6 +611,22 @@
> return snd_emu10k1_free(emu);
> }
>
> +/* vendor, device, subsystem, emu10k1_chip, emu10k2_chip, ca0102_chip, ca0108_chip, ca0151_chip, spk71, spdif_bug, ac97_chip, ecard, name */
> +
> +static emu_chip_details_t emu_chip_details[] = {
> + { 0x1102, 0x0008, 0x10011102, 0, 1, 0, 1, 0, 1, 0, 0, 0, "Audigy 2 Value [SB0400]"} ,
> + { 0x1102, 0x0008, 0x00000000, 0, 1, 0, 1, 0, 0, 0, 0, 0, "Audigy 2 Value [Unknown]"} ,
> + { 0x1102, 0x0004, 0x20071102, 0, 1, 1, 0, 1, 1, 0, 1, 0, "Audigy 4 PRO [SB0380]"} ,
> + { 0x1102, 0x0004, 0x20021102, 0, 1, 1, 0, 1, 1, 0, 1, 0, "Audigy 2 ZS [2002]"} ,
> + { 0x1102, 0x0004, 0x20011102, 0, 1, 1, 0, 1, 1, 0, 1, 0, "Audigy 2 ZS [2001]"} ,
> + { 0x1102, 0x0004, 0x10071102, 0, 1, 1, 0, 1, 1, 1, 1, 0, "Audigy 2 [SB0240]"} ,
> + { 0x1102, 0x0004, 0x10051102, 0, 1, 1, 0, 1, 0, 0, 0, 0, "Audigy 2 EX [1005]"} ,
> + { 0x1102, 0x0004, 0x00000000, 0, 1, 1, 0, 0, 0, 1, 0, 0, "Audigy 1 or 2 [Unknown]"} ,
> + { 0x1102, 0x0002, 0x40011102, 1, 0, 0, 0, 0, 0, 0, 0, 1, "E-mu APS [4001]"} ,
> + { 0x1102, 0x0002, 0x00000000, 1, 0, 0, 0, 0, 0, 0, 1, 0, "SB Live [Unknown]"} ,
> + { 0x0000, 0x0000, 0x00000000, 0, 0, 0, 0, 0, 0, 0, 0, 0, "Unknown"} ,
> +};
Can you rewrite in C99-init style, such as
{ .vendor = 0x1102, .device = 0x0004, .subsystem = 0x10051102,
.emu10k2_chip = 1, ... },
??
Takashi
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
next prev parent reply other threads:[~2005-03-21 19:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-18 20:04 [PATCH] Add framework for better audigy sound card capabilities selection buzzbuzz2
2005-03-21 19:47 ` Takashi Iwai [this message]
2005-03-21 21:22 ` James Courtier-Dutton
2005-03-22 9:56 ` Takashi Iwai
2005-03-22 19:30 ` James Courtier-Dutton
2005-03-22 19:48 ` James Courtier-Dutton
2005-03-22 20:59 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hbr9c4w80.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=buzzbuzz2@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox