From: Takashi Iwai <tiwai@suse.de>
To: Jim Minter <jminter@redhat.com>
Cc: alsa-devel@alsa-project.org, joschi.brauchle@tum.de
Subject: Re: No sound on Thinkpad T440s in Docking Station
Date: Fri, 27 Jun 2014 12:16:14 +0200 [thread overview]
Message-ID: <s5hd2duves1.wl%tiwai@suse.de> (raw)
In-Reply-To: <22733057.4.1403810610228.JavaMail.jminter@jminter>
At Thu, 26 Jun 2014 15:23:35 -0400 (EDT),
Jim Minter wrote:
>
> Hello,
>
> I'm getting the same issue reported by Joschi in May, but with a docked T540p. I can confirm that doing the following fixes the issue for me:
>
> ==== 8< ====
> # cat <<EOF >/lib/firmware/t540p.fw
> [codec]
> 0x10ec0292 0x17aa2210 0
>
> [pincfg]
> 0x16 0x21211010
> 0x19 0x21a11010
> EOF
>
> # cat <<EOF >/etc/modprobe.d/hda-intel.conf
> options snd-hda-intel patch=t540p.fw,t540p.fw,t540p.fw
> EOF
>
> Then rmmod/modprobe the snd-hda-intel kernel module, or just reboot.
> ==== 8< ====
>
> I can see http://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/?id=1c37c22332a2d2c1b4ab32177a4f847c7fe06e38 which I presume resolves this problem for T440s and T440p users.
>
> Please could an additional line, I'm guessing as follows, be added to sound/pci/hda/patch_realtek.c to include T540p users in this happy group?
>
> + SND_PCI_QUIRK(0x17aa, 0x2210, "Thinkpad T540p", ALC292_FIXUP_TPT440_DOCK),
>
> Thanks!
>
> Jim
OK, I applied the fixup now. Thanks for reporting!
Takashi
next prev parent reply other threads:[~2014-06-27 10:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <32716219.3.1403810435694.JavaMail.jminter@jminter>
2014-06-26 19:23 ` No sound on Thinkpad T440s in Docking Station Jim Minter
2014-06-27 10:16 ` Takashi Iwai [this message]
2014-04-30 8:56 Joschi Brauchle
2014-04-30 16:43 ` Takashi Iwai
2014-04-30 17:05 ` Joschi Brauchle
2014-05-02 7:31 ` Takashi Iwai
2014-05-02 8:16 ` Joschi Brauchle
2014-05-02 8:21 ` Takashi Iwai
2014-05-02 9:02 ` Joschi Brauchle
2014-05-02 9:27 ` Joschi Brauchle
2014-05-02 13:59 ` Joschi Brauchle
2014-05-06 9:46 ` Takashi Iwai
2014-05-06 13:49 ` Joschi Brauchle
2014-05-06 15:20 ` Joschi Brauchle
2014-05-06 15:41 ` Takashi Iwai
2014-05-07 9:28 ` Joschi Brauchle
2014-05-07 9:41 ` Takashi Iwai
2014-05-02 16:09 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2014-04-29 15:22 Joschi Brauchle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hd2duves1.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=jminter@redhat.com \
--cc=joschi.brauchle@tum.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox