Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: dmummenschanz@web.de
Cc: alsa-devel@alsa-project.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: Cannon Lake PCH cAVS (ALC892) not detected by kernel driver
Date: Mon, 14 Feb 2022 08:08:52 +0100	[thread overview]
Message-ID: <s5hfsolhqm3.wl-tiwai@suse.de> (raw)
In-Reply-To: <trinity-354a4a90-f564-4f73-bbea-ed00bc502c24-1644821395116@3c-app-webde-bs52>

On Mon, 14 Feb 2022 07:49:55 +0100,
dmummenschanz@web.de wrote:
> 
> Thanks for the scoop. I've added "options snd-hda-intel probe_mask=0x105" to /
> etc/modules-d/alsa.conf. Unfortunately that didn't help. The ALC892
> didn't show up. Why the log below says "codec_mask forced to 0x5" but I've
> explicitly set the value to 0x105 I don't know.

The bit 0x100 means to forcibly set the codec probe mask, so this is
fine.  But the actual work of the forced bit doesn't seem right.

Could you try the patch below and test with probe_mask=0x105 again?


thanks,

Takashi

--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -1798,8 +1798,6 @@ static int azx_create(struct snd_card *card, struct pci_dev *pci,
 
 	assign_position_fix(chip, check_position_fix(chip, position_fix[dev]));
 
-	check_probe_mask(chip, dev);
-
 	if (single_cmd < 0) /* allow fallback to single_cmd at errors */
 		chip->fallback_to_single_cmd = 1;
 	else /* explicitly set to single_cmd or not */
@@ -2280,6 +2278,8 @@ static int azx_probe_continue(struct azx *chip)
 	chip->beep_mode = beep_mode[dev];
 #endif
 
+	check_probe_mask(chip, dev);
+
 	/* create codec instances */
 	if (bus->codec_mask) {
 		err = azx_probe_codecs(chip, azx_max_codecs[chip->driver_type]);

  reply	other threads:[~2022-02-14  7:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08 18:46 Cannon Lake PCH cAVS (ALC892) not detected by kernel driver dmummenschanz
2022-02-08 21:55 ` Pierre-Louis Bossart
2022-02-09  7:14   ` Aw: " dmummenschanz
2022-02-09 15:51     ` Pierre-Louis Bossart
2022-02-09 16:47       ` Aw: " dmummenschanz
2022-02-12 11:33         ` dmummenschanz
2022-02-12 19:42           ` Pierre-Louis Bossart
2022-02-13  9:08             ` Takashi Iwai
2022-02-14  6:49               ` dmummenschanz
2022-02-14  7:08                 ` Takashi Iwai [this message]
2022-02-14  7:38                   ` dmummenschanz
2022-02-14  8:42                     ` Takashi Iwai
2022-02-14  9:23                       ` Aw: " dmummenschanz
2022-02-14  9:54                         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hfsolhqm3.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dmummenschanz@web.de \
    --cc=pierre-louis.bossart@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox