From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Jie Yang <yang.jie@linux.intel.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Mac Chiang <mac.chiang@intel.com>,
Bard Liao <bardliao@realtek.com>,
Bard liao <yung-chuan.liao@linux.intel.com>,
Jenny TC <jenny.tc@intel.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Hui Wang <hui.wang@canonical.com>,
Jon Flatley <jflat@chromium.org>,
Alexios Zavras <alexios.zavras@intel.com>,
Mark Brown <broonie@kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Naveen Manohar <naveen.m@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Ben Zhang <benzh@chromium.org>, Takashi Iwai <tiwai@suse.com>,
Sathya Prakash M R <sathya.prakash.m.r@intel.com>,
Curtis Malainey <cujomalainey@chromium.org>
Subject: Re: [alsa-devel] [PATCH v3] ASoC: intel: Add Broadwell rt5650 machine driver
Date: Fri, 06 Dec 2019 16:45:32 +0100 [thread overview]
Message-ID: <s5hfthxh2zn.wl-tiwai@suse.de> (raw)
In-Reply-To: <30321a90-a6fa-4f25-c02a-24ac9aa69709@linux.intel.com>
On Fri, 06 Dec 2019 16:31:20 +0100,
Pierre-Louis Bossart wrote:
>
>
>
> On 12/5/19 7:34 PM, Curtis Malainey wrote:
> > From: Ben Zhang <benzh@chromium.org>
> >
> > Add machine driver for Broadwell + rt5650.
> >
> > Signed-off-by: Bard Liao <bardliao@realtek.com>
> > Signed-off-by: Ben Zhang <benzh@chromium.org>
> > Signed-off-by: Mac Chiang <mac.chiang@intel.com>
> > Signed-off-by: Jon Flatley <jflat@chromium.org>
> > Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
>
> sounds good, but it'd be nice to fix the Sparse warning below
>
> bdw-rt5650.c:102:37: warning: incorrect type in argument 2 (different
> base types)
> bdw-rt5650.c:102:37: expected unsigned int val
> bdw-rt5650.c:102:37: got restricted snd_pcm_format_t [usertype]
>
> We introduced a new function to deal with this, can't recall off the
> top of my head.
It's snd_mask_set_format(). The open code in this patch
snd_mask_set(¶ms->masks[SNDRV_PCM_HW_PARAM_FORMAT -
SNDRV_PCM_HW_PARAM_FIRST_MASK],
SNDRV_PCM_FORMAT_S24_LE);
is replaced with
snd_mask_set_format(hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT),
SNDRV_PCM_FORMAT_S24_LE);
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2019-12-06 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 1:34 [alsa-devel] [PATCH v3] ASoC: intel: Add Broadwell rt5650 machine driver Curtis Malainey
2019-12-06 15:31 ` Pierre-Louis Bossart
2019-12-06 15:45 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hfthxh2zn.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alexios.zavras@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=benzh@chromium.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cujomalainey@chromium.org \
--cc=hui.wang@canonical.com \
--cc=jenny.tc@intel.com \
--cc=jflat@chromium.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=krzk@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mac.chiang@intel.com \
--cc=naveen.m@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sathya.prakash.m.r@intel.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox