From: Takashi Iwai <tiwai@suse.de>
To: Brent Lu <brent.lu@intel.com>
Cc: "Guennadi Liakhovetski" <guennadi.liakhovetski@linux.intel.com>,
alsa-devel@alsa-project.org,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Mark Brown" <broonie@kernel.org>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Subject: Re: [PATCH] ASoC: hdac_hdmi: support 'ELD' mixer
Date: Sun, 16 Aug 2020 09:50:47 +0200 [thread overview]
Message-ID: <s5hh7t3qbag.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200814083436.19845-1-brent.lu@intel.com>
On Fri, 14 Aug 2020 10:34:36 +0200,
Brent Lu wrote:
> @@ -1784,6 +1913,16 @@ int hdac_hdmi_jack_init(struct snd_soc_dai *dai, int device,
> }
> }
>
> + /* add control for ELD Bytes */
> + err = hdac_hdmi_create_eld_ctl(component, pcm);
> + if (err < 0) {
> + dev_err(&hdev->dev,
> + "eld control add failed with err: %d for pcm: %d\n",
> + err, device);
> + kfree(pcm);
pcm is allocated vida devm_kzalloc(), hence you shoudn't free it
explicitly.
thanks,
Takashi
next prev parent reply other threads:[~2020-08-16 7:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 8:34 [PATCH] ASoC: hdac_hdmi: support 'ELD' mixer Brent Lu
2020-08-16 7:50 ` Takashi Iwai [this message]
2020-08-18 0:53 ` Lu, Brent
2020-08-18 0:44 ` [PATCH v2] " Brent Lu
2020-08-18 11:45 ` Kai Vehmanen
2020-08-18 14:49 ` Lu, Brent
2020-08-18 14:36 ` [PATCH v3] " Brent Lu
2020-08-18 15:02 ` Mark Brown
2020-08-18 15:22 ` Lu, Brent
2020-08-18 17:10 ` Mark Brown
2020-08-18 16:54 ` Mark Brown
2020-08-18 17:39 ` Mark Brown
2020-08-18 16:55 ` [PATCH v2] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hh7t3qbag.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox