From: Takashi Iwai <tiwai@suse.de>
To: Adam Miartus <amiartus@de.adit-jv.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [ALSA patch] [PATCH 0/2 v2] Open Alsa dshare without channel binding
Date: Wed, 24 Jul 2019 15:20:27 +0200 [thread overview]
Message-ID: <s5hh87b36xw.wl-tiwai@suse.de> (raw)
In-Reply-To: <1563963180-416-1-git-send-email-amiartus@de.adit-jv.com>
On Wed, 24 Jul 2019 12:12:58 +0200,
Adam Miartus wrote:
>
> The general idea of this patch is to be able to open the device without
> defined bindings. As a result, it allows starting the audio clock of
> underlying device without blocking a channel.
>
> This might be useful for creating a dummy dsnoop pcm for hardware that
> requires running clock early at system start. This clock is then present
> even without application streaming audio data.
>
> Patch n.1 is intended to check for null pointer of pcm callbacks,
> it is not intended to alter any current functionality, properly defined
> plugins should not suffer from this change
>
> Patch n.2 is not intended to alter any current functionality, only
> extend it
>
> V2 of the patch, changes from V1:
> - instead of creating new "pcm_unsupported.c" with ops and fast_ops
> callbacks returning -ENOSYS, callback == NULL is checked directly
> in core implementation and error is returned when pcm has no
> callback defined
Looks much better now to me. Applied both patches.
Thanks!
Takashi
prev parent reply other threads:[~2019-07-24 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 10:12 [PATCH 0/2 v2] Open Alsa dshare without channel binding Adam Miartus
2019-07-24 10:12 ` [PATCH 1/2] alsa: pcm: return -ENOSYS when ops or fast_ops callback is NULL Adam Miartus
2019-07-24 10:13 ` [PATCH 2/2] alsa: dshare: allow missing bindings Adam Miartus
2019-07-24 13:20 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hh87b36xw.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=amiartus@de.adit-jv.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox