From: Takashi Iwai <tiwai@suse.de>
To: Krzysztof Helt <krzysztof.h1@wp.pl>
Cc: alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: [PATCH] sparc dbri: hardware constrains added
Date: Wed, 23 Aug 2006 11:39:31 +0200 [thread overview]
Message-ID: <s5hhd03ssdo.wl%tiwai@suse.de> (raw)
In-Reply-To: <44eb445108302@wp.pl>
At Tue, 22 Aug 2006 19:52:17 +0200,
Krzysztof Helt wrote:
>
> From: Krzysztof Helt (krzysztof.h1@wp.pl)
>
> This patch adds ALSA hardware constrains so stereo is possible
> only with 16-bit format. It contains small cleanups to ring
> buffered code as well.
>
> Signed-off-by: Krzysztof Helt (krzysztof.h1@wp.pl)
Missing braces in debug prints of dbri_cmdsend(), but others look
fine. I queued the fixed patch on my tree. Will be committed to the
upstream soon.
BTW, dprintk() should use "do { } while (0)" so that it can be used
safely without extra blocks.
Thanks,
Takashi
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
next prev parent reply other threads:[~2006-08-23 9:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-22 17:52 [PATCH] sparc dbri: hardware constrains added Krzysztof Helt
2006-08-23 9:39 ` Takashi Iwai [this message]
2006-08-23 10:53 ` Krzysztof Helt
2006-08-23 18:18 ` Takashi Iwai
2006-08-24 6:14 ` Krzysztof Helt
2006-08-24 19:05 ` Krzysztof Helt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hhd03ssdo.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@lists.sourceforge.net \
--cc=krzysztof.h1@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).