EAPD turn on later

EAPD turn on later

[Kailang]

[-- Attachment #1: Type: text/plain, Size: 132 bytes --]

Hi Takashi,

EAPD need to turn on after set pin output.
This will avoid pop noise for more machine via speaker.

BR,
Kailang

[-- Attachment #2: 0000-eapd-on-later.patch --]
[-- Type: application/octet-stream, Size: 792 bytes --]

From d777dcc48a37ce5d10e20a6bf587c3c110ff467c Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Fri, 26 Apr 2019 16:35:41 +0800
Subject: [PATCH] ALSA: hda/realtek - EAPD turn on later

Let EAPD turn on after set pin output.

Signed-off-by: Kailang Yang <kailang@realtek.com>

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f5b510f119ed..1d0e0f2e6526 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -803,11 +803,10 @@ static int alc_init(struct hda_codec *codec)
 	if (spec->init_hook)
 		spec->init_hook(codec);
 
+	snd_hda_gen_init(codec);
 	alc_fix_pll(codec);
 	alc_auto_init_amp(codec, spec->init_amp);
 
-	snd_hda_gen_init(codec);
-
 	snd_hda_apply_fixup(codec, HDA_FIXUP_ACT_INIT);
 
 	return 0;

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: EAPD turn on later

[Takashi Iwai]

On Fri, 26 Apr 2019 10:46:04 +0200,
Kailang wrote:
> 
> Hi Takashi,
> 
> EAPD need to turn on after set pin output.
> This will avoid pop noise for more machine via speaker.

OK, applied now but to for-next branch (i.e. 5.2 kernel) since this
affects all Realtek codecs.  Although it's likely safe, let's be
conservative.


thanks,

Takashi