From: Takashi Iwai <tiwai@suse.de>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, josh@joshtriplett.org
Subject: Re: [PATCH 1/3] sound: Include appropriate header file in pcsp/pcsp_input.c
Date: Fri, 07 Feb 2014 18:25:15 +0100 [thread overview]
Message-ID: <s5hlhxmsumc.wl%tiwai@suse.de> (raw)
In-Reply-To: <512472c7d96cf1c239ba3d0bc517891a7c2f9da1.1391791103.git.rashika.kheria@gmail.com>
At Fri, 7 Feb 2014 22:11:53 +0530,
Rashika Kheria wrote:
>
> Include appropriate header file in drivers/pcsp/pcsp_input.c because it
> defines function whose prototype definitions are present in
> drivers/pcsp/pcsp_input.h.
>
> This eliminates the following warning in drivers/pcsp/pcsp_input.c:
> sound/drivers/pcsp/pcsp_input.c:42:6: warning: no previous prototype for ‘pcspkr_stop_sound’ [-Wmissing-prototypes]
> sound/drivers/pcsp/pcsp_input.c:80:5: warning: no previous prototype for ‘pcspkr_input_init’ [-Wmissing-prototypes]
> sound/drivers/pcsp/pcsp_input.c:110:5: warning: no previous prototype for ‘pcspkr_input_remove’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Thanks, applied all three patches.
Takashi
> ---
> sound/drivers/pcsp/pcsp_input.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/drivers/pcsp/pcsp_input.c b/sound/drivers/pcsp/pcsp_input.c
> index b874b0a..0ecf8a4 100644
> --- a/sound/drivers/pcsp/pcsp_input.c
> +++ b/sound/drivers/pcsp/pcsp_input.c
> @@ -16,6 +16,7 @@
> #include <linux/input.h>
> #include <asm/io.h>
> #include "pcsp.h"
> +#include "pcsp_input.h"
>
> static void pcspkr_do_sound(unsigned int count)
> {
> --
> 1.7.9.5
>
prev parent reply other threads:[~2014-02-07 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 16:41 [PATCH 1/3] sound: Include appropriate header file in pcsp/pcsp_input.c Rashika Kheria
2014-02-07 16:44 ` [PATCH 2/3] sound: Remove unused function in pci/lx6464es/lx_core.c Rashika Kheria
2014-02-07 17:22 ` Josh Triplett
2014-02-07 16:46 ` [PATCH 3/3] sound: Move prototype declaration to header file oss/pas2.h from oss/pas2_card.c Rashika Kheria
2014-02-07 17:23 ` Josh Triplett
2014-02-07 17:22 ` [PATCH 1/3] sound: Include appropriate header file in pcsp/pcsp_input.c Josh Triplett
2014-02-07 17:25 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hlhxmsumc.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox