From: Takashi Iwai <tiwai@suse.de>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH] ALSA: hda: enable regmap internal locking
Date: Wed, 08 Jan 2020 20:12:13 +0100 [thread overview]
Message-ID: <s5hmuaxn4oi.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200108180856.5194-1-kai.vehmanen@linux.intel.com>
On Wed, 08 Jan 2020 19:08:56 +0100,
Kai Vehmanen wrote:
>
> This reverts commit 42ec336f1f9d ("ALSA: hda: Disable regmap
> internal locking").
>
> Without regmap locking, there is a race between snd_hda_codec_amp_init()
> and PM callbacks issuing regcache_sync(). This was caught by
> following kernel warning trace:
>
> <4> [358.080081] WARNING: CPU: 2 PID: 4157 at drivers/base/regmap/regcache.c:498 regcache_cache_only+0xf5/0x130
> [...]
> <4> [358.080148] Call Trace:
> <4> [358.080158] snd_hda_codec_amp_init+0x4e/0x100 [snd_hda_codec]
> <4> [358.080169] snd_hda_codec_amp_init_stereo+0x40/0x80 [snd_hda_codec]
>
> Suggested-by: Takashi Iwai <tiwai@suse.de>
> BugLink: https://gitlab.freedesktop.org/drm/intel/issues/592
> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Applied now. Thanks.
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2020-01-08 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 18:08 [alsa-devel] [PATCH] ALSA: hda: enable regmap internal locking Kai Vehmanen
2020-01-08 19:12 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmuaxn4oi.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kai.vehmanen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox