Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Klaus Ethgen <Klaus@ethgen.ch>
Cc: alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] CPU hook snd_hda_intel
Date: Mon, 09 Dec 2019 08:10:08 +0100	[thread overview]
Message-ID: <s5hmuc2asa7.wl-tiwai@suse.de> (raw)
In-Reply-To: <20191208173127.GE4433@ikki.ethgen.ch>

On Sun, 08 Dec 2019 18:31:27 +0100,
Klaus Ethgen wrote:
> 
> Hi Takashi,
> 
> Am So den  8. Dez 2019 um  9:45 schrieb Takashi Iwai:
> > On Sat, 07 Dec 2019 21:06:43 +0100,
> > > Find attached the perf output of the relevant event handler.
> > 
> > Thanks.  So it seems wasting in the busy loop for waiting for the
> > response from the codec.
> > 
> > How about a patch below?  It's untested, might break things, but at
> > least avoiding a busy loop.
> 
> I'll give it a try. Kernel is compiling right now. It might be hard to
> see if the patch is working but I suppose that it do when I don't have
> that trouble within a week or so.
> 
> > BTW, if your machine is Coffeelake or Cannonlake, this patch wont'
> > work on the old branch because of forced polling mode.  It was removed
> > in 5.5-rc1, so please test with Linus tree at best.
> 
> I hardly have such new Architectures on that laptop. It is a lenovo x61s
> so it is from latest 2009. It has a Intel Core 2 Duo LV (Merom). :-)

OK, then could you give alsa-info.sh output, at least?
Run the script with --no-upload option and attach the output.

Basically my patch should improve a lot for Nvidia codecs, not only
about the CPU time reduction, and it'd be worth for merging to
upstream.  OTOH, it's a change at the very core part, so it needs more
testing, so it's likely for 5.6.


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-12-09  7:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 18:47 [alsa-devel] CPU hook snd_hda_intel Klaus Ethgen
2019-12-04 16:31 ` Takashi Iwai
2019-12-07 20:06   ` Klaus Ethgen
2019-12-08  8:45     ` Takashi Iwai
2019-12-08 17:31       ` Klaus Ethgen
2019-12-09  7:10         ` Takashi Iwai [this message]
2019-12-09  8:57           ` Klaus Ethgen
2019-12-09  9:27             ` Takashi Iwai
2019-12-09  9:45               ` Klaus Ethgen
2019-12-10 14:32               ` Klaus Ethgen
2019-12-10 14:35               ` Klaus Ethgen
2019-12-10 14:43                 ` Takashi Iwai
2019-12-10 15:10                   ` Klaus Ethgen
2019-12-10 15:19                     ` Takashi Iwai
2019-12-10 15:28                       ` Klaus Ethgen
2019-12-23 17:18                       ` Klaus Ethgen
2019-12-23 22:14                         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hmuc2asa7.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=Klaus@ethgen.ch \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox