* [PATCH] sound: pci: asihpi: Remove unneeded variable change
@ 2019-07-05 2:57 Hariprasad Kelam
2019-07-05 6:19 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Hariprasad Kelam @ 2019-07-05 2:57 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Richard Fontana, Colin Ian King,
Hariprasad Kelam, Allison Randal, Thomas Gleixner, alsa-devel,
linux-kernel
this patch fixes below issue reported by coccicheck
sound/pci/asihpi/asihpi.c:1558:5-11: Unneeded variable: "change". Return
"1" on line 1564
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
sound/pci/asihpi/asihpi.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/sound/pci/asihpi/asihpi.c b/sound/pci/asihpi/asihpi.c
index e7234f3..2a21a3d 100644
--- a/sound/pci/asihpi/asihpi.c
+++ b/sound/pci/asihpi/asihpi.c
@@ -1519,7 +1519,6 @@ static int snd_asihpi_volume_get(struct snd_kcontrol *kcontrol,
static int snd_asihpi_volume_put(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)
{
- int change;
u32 h_control = kcontrol->private_value;
short an_gain_mB[HPI_MAX_CHANNELS];
@@ -1530,9 +1529,8 @@ static int snd_asihpi_volume_put(struct snd_kcontrol *kcontrol,
/* change = asihpi->mixer_volume[addr][0] != left ||
asihpi->mixer_volume[addr][1] != right;
*/
- change = 1;
hpi_handle_error(hpi_volume_set_gain(h_control, an_gain_mB));
- return change;
+ return 1;
}
static const DECLARE_TLV_DB_SCALE(db_scale_100, -10000, VOL_STEP_mB, 0);
@@ -1555,13 +1553,12 @@ static int snd_asihpi_volume_mute_put(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)
{
u32 h_control = kcontrol->private_value;
- int change = 1;
/* HPI currently only supports all or none muting of multichannel volume
ALSA Switch element has opposite sense to HPI mute: on==unmuted, off=muted
*/
int mute = ucontrol->value.integer.value[0] ? 0 : HPI_BITMASK_ALL_CHANNELS;
hpi_handle_error(hpi_volume_set_mute(h_control, mute));
- return change;
+ return 1;
}
static int snd_asihpi_volume_add(struct snd_card_asihpi *asihpi,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sound: pci: asihpi: Remove unneeded variable change
2019-07-05 2:57 [PATCH] sound: pci: asihpi: Remove unneeded variable change Hariprasad Kelam
@ 2019-07-05 6:19 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2019-07-05 6:19 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: alsa-devel, Colin Ian King, Thomas Gleixner, Allison Randal,
Jaroslav Kysela, Richard Fontana, Takashi Iwai, linux-kernel
On Fri, 05 Jul 2019 04:57:33 +0200,
Hariprasad Kelam wrote:
>
> this patch fixes below issue reported by coccicheck
> sound/pci/asihpi/asihpi.c:1558:5-11: Unneeded variable: "change". Return
> "1" on line 1564
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-05 6:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-05 2:57 [PATCH] sound: pci: asihpi: Remove unneeded variable change Hariprasad Kelam
2019-07-05 6:19 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox