Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Hui Wang <hui.wang@canonical.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 1/2] ALSA: hda/hdmi - Read the pin sense from register when repolling
Date: Mon, 06 May 2019 16:26:59 +0200	[thread overview]
Message-ID: <s5hmujz4q18.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190506140932.7942-1-hui.wang@canonical.com>

On Mon, 06 May 2019 16:09:31 +0200,
Hui Wang wrote:
> 
> The driver will check the monitor presence when resuming from suspend,
> starting poll or interrupt triggers. In these 3 situations, the
> jack_dirty will be set to 1 first, then the hda_jack.c reads the
> pin_sense from register, after reading the register, the jack_dirty
> will be set to 0. But hdmi_repoll_work() is enabled in these 3
> situations, It will read the pin_sense a couple of times subsequently,
> since the jack_dirty is 0 now, It does not read the register anymore,
> instead it uses the shadow pin_sense which is read at the first time.
> 
> It is meaningless to check the shadow pin_sense a couple of times,
> we need to read the register to check the real plugging state, so
> we set the jack_dirty to 1 in the hdmi_repoll_work().
> 
> Signed-off-by: Hui Wang <hui.wang@canonical.com>

Thanks, applied both patches.
They deserve for Cc-to-stable, so I added it.


Takashi

  parent reply	other threads:[~2019-05-06 14:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-06 14:09 [PATCH v2 1/2] ALSA: hda/hdmi - Read the pin sense from register when repolling Hui Wang
2019-05-06 14:09 ` [PATCH v2 2/2] ALSA: hda/hdmi - Consider eld_valid when reporting jack event Hui Wang
2019-05-06 14:26 ` Takashi Iwai [this message]
2019-05-06 14:31 ` [PATCH v2 1/2] ALSA: hda/hdmi - Read the pin sense from register when repolling Takashi Iwai
2019-05-06 23:29   ` Hui Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hmujz4q18.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=hui.wang@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox