From: Takashi Iwai <tiwai@suse.de>
To: Hui Wang <hui.wang@canonical.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 1/2] ALSA: hda/hdmi - Read the pin sense from register when repolling
Date: Mon, 06 May 2019 16:31:15 +0200 [thread overview]
Message-ID: <s5himun4pu4.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190506140932.7942-1-hui.wang@canonical.com>
On Mon, 06 May 2019 16:09:31 +0200,
Hui Wang wrote:
>
> @@ -1663,6 +1663,11 @@ static void hdmi_repoll_eld(struct work_struct *work)
> container_of(to_delayed_work(work), struct hdmi_spec_per_pin, work);
> struct hda_codec *codec = per_pin->codec;
> struct hdmi_spec *spec = codec->spec;
> + struct hda_jack_tbl *jack;
> +
> + jack = snd_hda_jack_tbl_get(codec, per_pin->pin_nid);
> + if (jack)
> + jack = jack->jack_dirty = 1;
Oh, and I corrected the obvious typo above manually while applying.
We don't need to substitute jack twice.
Takashi
next prev parent reply other threads:[~2019-05-06 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 14:09 [PATCH v2 1/2] ALSA: hda/hdmi - Read the pin sense from register when repolling Hui Wang
2019-05-06 14:09 ` [PATCH v2 2/2] ALSA: hda/hdmi - Consider eld_valid when reporting jack event Hui Wang
2019-05-06 14:26 ` [PATCH v2 1/2] ALSA: hda/hdmi - Read the pin sense from register when repolling Takashi Iwai
2019-05-06 14:31 ` Takashi Iwai [this message]
2019-05-06 23:29 ` Hui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5himun4pu4.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=hui.wang@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox