* [PATCH] alsabat: make snr_is_valid static
@ 2016-07-19 9:05 Vinod Koul
2016-07-20 5:23 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Vinod Koul @ 2016-07-19 9:05 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai, han.lu, Vinod Koul
The compilation fails due to multiple defination of snr_is_valid
common.o: In function `snr_is_valid':
bat/common.h:99: multiple definition of `snr_is_valid'
bat.o:bat/common.h:99: first defined here
signal.o: In function `snr_is_valid':
bat/common.h:99: multiple definition of `snr_is_valid'
bat.o:bat/common.h:99: first defined here
latencytest.o: In function `snr_is_valid':
bat/common.h:99: multiple definition of `snr_is_valid'
bat.o:bat/common.h:99: first defined here
analyze.o: In function `snr_is_valid':
bat/common.h:99: multiple definition of `snr_is_valid'
bat.o:bat/common.h:99: first defined here
alsa.o: In function `snr_is_valid':
bat/common.h:99: multiple definition of `snr_is_valid'
bat.o:bat/common.h:99: first defined here
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
bat/common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bat/common.h b/bat/common.h
index db49868a419a..1b07fbeb7755 100644
--- a/bat/common.h
+++ b/bat/common.h
@@ -94,7 +94,7 @@
#define SNR_DB_MIN 0.0
#define SNR_DB_MAX 200.0
-inline bool snr_is_valid(float db)
+static inline bool snr_is_valid(float db)
{
return (db > SNR_DB_MIN && db < SNR_DB_MAX);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] alsabat: make snr_is_valid static
2016-07-19 9:05 [PATCH] alsabat: make snr_is_valid static Vinod Koul
@ 2016-07-20 5:23 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2016-07-20 5:23 UTC (permalink / raw)
To: Vinod Koul; +Cc: han.lu, alsa-devel
On Tue, 19 Jul 2016 11:05:09 +0200,
Vinod Koul wrote:
>
> The compilation fails due to multiple defination of snr_is_valid
>
> common.o: In function `snr_is_valid':
> bat/common.h:99: multiple definition of `snr_is_valid'
> bat.o:bat/common.h:99: first defined here
>
> signal.o: In function `snr_is_valid':
> bat/common.h:99: multiple definition of `snr_is_valid'
> bat.o:bat/common.h:99: first defined here
>
> latencytest.o: In function `snr_is_valid':
> bat/common.h:99: multiple definition of `snr_is_valid'
> bat.o:bat/common.h:99: first defined here
>
> analyze.o: In function `snr_is_valid':
> bat/common.h:99: multiple definition of `snr_is_valid'
> bat.o:bat/common.h:99: first defined here
>
> alsa.o: In function `snr_is_valid':
> bat/common.h:99: multiple definition of `snr_is_valid'
> bat.o:bat/common.h:99: first defined here
>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-20 5:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-19 9:05 [PATCH] alsabat: make snr_is_valid static Vinod Koul
2016-07-20 5:23 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox