[PATCH]Device ID for Toshiba laptop which uses AD1986A

[PATCH]Device ID for Toshiba laptop which uses AD1986A

[Jiang zhe]

Hi,

Please refer to the [0003662].
The model laptop-eapd get rid of the high-pitched noise.

Signed-Off-by: Jiang Zhe <zhe.jiang@intel.com>
--- alsa-driver-hg20071219/alsa-kernel/pci/hda/patch_analog.c	2007-12-20
09:40:37.000000000 +0800
+++ b/alsa-kernel/pci/hda/patch_analog.c	2007-12-20 09:23:05.000000000
+0800
@@ -859,6 +859,7 @@ static struct snd_pci_quirk ad1986a_cfg_
 	SND_PCI_QUIRK(0x17aa, 0x1017, "Lenovo A60", AD1986A_3STACK),
 	SND_PCI_QUIRK(0x17aa, 0x2066, "Lenovo N100", AD1986A_LAPTOP_AUTOMUTE),
 	SND_PCI_QUIRK(0x17c0, 0x2017, "Samsung M50", AD1986A_LAPTOP),
+	SND_PCI_QUIRK(0x1179, 0xff40, "Toshiba", AD1986A_LAPTOP_EAPD),
 	{}
 };

Re: [PATCH]Device ID for Toshiba laptop which uses AD1986A

[Takashi Iwai]

At Thu, 20 Dec 2007 09:44:14 +0800,
Jiang zhe wrote:
> 
> Hi,
> 
> Please refer to the [0003662].
> The model laptop-eapd get rid of the high-pitched noise.
> 
> Signed-Off-by: Jiang Zhe <zhe.jiang@intel.com>

The high-pitched noise should be fixed with other models, too, but
after 1.0.15 release.  It was a general problem of AD1986A.

Meanwhile, if the machine is a laptop, this model matches certainly
better than the default one.

So, applied to HG tree now.  Thanks.


Takashi

> --- alsa-driver-hg20071219/alsa-kernel/pci/hda/patch_analog.c	2007-12-20
> 09:40:37.000000000 +0800
> +++ b/alsa-kernel/pci/hda/patch_analog.c	2007-12-20 09:23:05.000000000
> +0800
> @@ -859,6 +859,7 @@ static struct snd_pci_quirk ad1986a_cfg_
>  	SND_PCI_QUIRK(0x17aa, 0x1017, "Lenovo A60", AD1986A_3STACK),
>  	SND_PCI_QUIRK(0x17aa, 0x2066, "Lenovo N100", AD1986A_LAPTOP_AUTOMUTE),
>  	SND_PCI_QUIRK(0x17c0, 0x2017, "Samsung M50", AD1986A_LAPTOP),
> +	SND_PCI_QUIRK(0x1179, 0xff40, "Toshiba", AD1986A_LAPTOP_EAPD),
>  	{}
>  };
>  
> 

Re: [PATCH]Device ID for Toshiba laptop which uses AD1986A

[Jiang zhe]

On Fri, 2007-12-21 at 21:39 +0200, Andy Shevchenko wrote:
> Hi Jiang zhe!
> 
>  On Thu, Dec 20, 2007 at 09:44:14AM +0800, Jiang zhe wrote next:
> 
> > @@ -859,6 +859,7 @@ static struct snd_pci_quirk ad1986a_cfg_
> >  	SND_PCI_QUIRK(0x17aa, 0x1017, "Lenovo A60", AD1986A_3STACK),
> >  	SND_PCI_QUIRK(0x17aa, 0x2066, "Lenovo N100", AD1986A_LAPTOP_AUTOMUTE),
> >  	SND_PCI_QUIRK(0x17c0, 0x2017, "Samsung M50", AD1986A_LAPTOP),
> > +	SND_PCI_QUIRK(0x1179, 0xff40, "Toshiba", AD1986A_LAPTOP_EAPD),
> >  	{}
> >  };
> Please, keep list sorted by PCI SSID.
> 

Thank you very much! ^_^

--- alsa-driver-hg20071224/alsa-kernel/pci/hda/patch_analog.c	2007-12-21
09:00:06.000000000 +0800
+++ b/alsa-kernel/pci/hda/patch_analog.c	2007-12-24 10:07:54.000000000
+0800
@@ -848,6 +848,7 @@ static struct snd_pci_quirk ad1986a_cfg_
 	SND_PCI_QUIRK(0x1043, 0x81cb, "ASUS M2N", AD1986A_3STACK),
 	SND_PCI_QUIRK(0x1043, 0x8234, "ASUS M2N", AD1986A_3STACK),
 	SND_PCI_QUIRK(0x10de, 0xcb84, "ASUS A8N-VM", AD1986A_3STACK),
+	SND_PCI_QUIRK(0x1179, 0xff40, "Toshiba", AD1986A_LAPTOP_EAPD),
 	SND_PCI_QUIRK(0x144d, 0xb03c, "Samsung R55", AD1986A_3STACK),
 	SND_PCI_QUIRK(0x144d, 0xc01e, "FSC V2060", AD1986A_LAPTOP),
 	SND_PCI_QUIRK(0x144d, 0xc023, "Samsung X60", AD1986A_LAPTOP_EAPD),
@@ -859,7 +860,6 @@ static struct snd_pci_quirk ad1986a_cfg_
 	SND_PCI_QUIRK(0x17aa, 0x1017, "Lenovo A60", AD1986A_3STACK),
 	SND_PCI_QUIRK(0x17aa, 0x2066, "Lenovo N100", AD1986A_LAPTOP_AUTOMUTE),
 	SND_PCI_QUIRK(0x17c0, 0x2017, "Samsung M50", AD1986A_LAPTOP),
-	SND_PCI_QUIRK(0x1179, 0xff40, "Toshiba", AD1986A_LAPTOP_EAPD),
 	{}
 };