Re: PATCH - ESI Juli driver

[Takashi Iwai <tiwai@suse.de>]

At Sun, 16 Mar 2008 13:57:24 +0100,
Pavel Hofman wrote:
> 
> Hi Takashi,
> 
> Juli support required some changes to ice1724.c/ice1712.h. Since Juli 
> uses different clock scheme than most other ice1712/24 cards, I had to 
> move all clock-specific code to card-specific routines. Most of them are 
> redefined in juli.c.

I feel there are too many additional callbacks in your patch.
Since we don't need too subtle tuning, can we simplify this?

Regarding the separate rate setting for each stream, we should
consider about Maya44 support, too.

> The driver is tested, only analog-in and digital-in monitors are not 
> working. I have coded according to manufacturer's documentation, the 
> same procedure is in OSS Juli driver. I described the issue in detail in 
> the code, perhaps someone will do more research.
> 
> The card itself has no HW master volume control. It would have to be 
> implemented as a virtual control manipulating internal values of PCM and 
> monitor volume controls. I will take a look at it later. For now, 
> perhaps we could rename the PCM Volume to Master Volume, as most people 
> will not need the monitoring anyway. I will leave it to your decision.
> 
> Signed-off-by: Pavel Hofman <dustin@seznam.cz>
> 
> * moving all clock-specific code to card-specific routines
> * support for ESI Juli
> * to-be-researched - monitoring of analog/digital inputs
> * missing - master volume control, will have to be implemented as 
> virtual, no HW support.

vmaster can be used for this now.  It was moved to core directory
after 1.0.16 release.


thanks,

Takashi