From: Takashi Iwai <tiwai@suse.de>
To: Andrew Paprocki <andrew@ishiboo.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] hda-codec - Fix definition of AC_KNBCAP_DELTA to match datasheet.
Date: Thu, 13 Dec 2007 12:08:09 +0100 [thread overview]
Message-ID: <s5hodcukg2u.wl%tiwai@suse.de> (raw)
In-Reply-To: <76366b180712032312p73a98249hf9269e5044a818c2@mail.gmail.com>
At Tue, 4 Dec 2007 02:12:48 -0500,
Andrew Paprocki wrote:
>
> hda-codec - Fix definition of AC_KNBCAP_DELTA to match datasheet.
>
> AC_KNBCAP_DELTA is incorrectly defined as (1<<8). According to the ALC883
> datasheet rev 1.3, this is bit 7 after AC_KNBCAP_NUM_STEPS which is a 0x7f
> mask.
>
> Signed-off-by: Andrew Paprocki <andrew@ishiboo.com>
This is a broken patch, too. Please fix.
Thanks,
Takashi
>
>
> diff -r da002fb740a42b4fd6dcbd45693f9bee3c828812 -r
> 65b577e690e95e4ace950c3f986270dd3e992192 pci/hda/hda_codec.h
> --- a/pci/hda/hda_codec.h Mon Dec 03 22:52:58 2007 -0500
> +++ b/pci/hda/hda_codec.h Mon Dec 03 23:02:51 2007 -0500
> @@ -238,7 +238,7 @@ enum {
>
> /* Volume knobs capabilities */
> #define AC_KNBCAP_NUM_STEPS (0x7f<<0)
> -#define AC_KNBCAP_DELTA (1<<8)
> +#define AC_KNBCAP_DELTA (1<<7)
>
> /*
> * Control Parameters
>
prev parent reply other threads:[~2007-12-13 12:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 7:12 [PATCH] hda-codec - Fix definition of AC_KNBCAP_DELTA to match datasheet Andrew Paprocki
2007-12-13 11:08 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hodcukg2u.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@ishiboo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox