From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
workgroup.linux@csr.com, Rongjun Ying <rongjun.ying@csr.com>,
RongJun Ying <rjying@gmail.com>
Subject: Re: [PATCH v4 0/7] ASoC: add CSR SiRFSoC sound drivers
Date: Thu, 27 Feb 2014 09:09:21 +0100 [thread overview]
Message-ID: <s5hppm9m0y6.wl%tiwai@suse.de> (raw)
In-Reply-To: <20140227043856.GI9383@sirena.org.uk>
At Thu, 27 Feb 2014 13:38:56 +0900,
Mark Brown wrote:
>
> On Wed, Feb 26, 2014 at 07:35:12AM +0100, Takashi Iwai wrote:
>
> > Are there anything else you want to say except for these subject
> > lines? The empty changelog for such big changes doesn't look good.
>
> For new drivers it's more acceptable, though - if the driver isn't doing
> anything exciting (and a lot of them won't be) there's often not much to
> say. A lot of the changelogs you see are just a bit of the marketing
> blurb from the datasheet.
True, but it may be still useful for reviewing. At least, you can
know the expected hardware features provided by the driver in the
changelog before you start reviewing. Otherwise you have no clue
whether it's implementing the right thing.
Takashi
prev parent reply other threads:[~2014-02-27 8:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 6:04 [PATCH v4 0/7] ASoC: add CSR SiRFSoC sound drivers RongJun Ying
2014-02-26 6:04 ` [PATCH v4 1/7] ASoC: sirf: Add SiRF internal audio codec driver RongJun Ying
2014-02-26 6:04 ` [PATCH v4 2/7] ASoC: sirf: Add SiRF audio port driver is used by SiRF internal audio codec RongJun Ying
2014-02-26 6:04 ` [PATCH v4 3/7] ASoC: sirf: Add SiRF audio card RongJun Ying
2014-02-26 6:04 ` [PATCH v4 4/7] ASoC: sirf: Add SiRF I2S driver RongJun Ying
2014-02-26 6:04 ` [PATCH v4 5/7] ASoC: sirf: Add hdmi card RongJun Ying
2014-02-26 6:04 ` [PATCH v4 6/7] ASoC: sirf: Add usp driver which is used by dsp mode RongJun Ying
2014-02-26 6:04 ` [PATCH v4 7/7] ASoC: sirf: Add bt-sco card RongJun Ying
2014-02-26 6:35 ` [PATCH v4 0/7] ASoC: add CSR SiRFSoC sound drivers Takashi Iwai
2014-02-27 4:38 ` Mark Brown
2014-02-27 8:09 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hppm9m0y6.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=rjying@gmail.com \
--cc=rongjun.ying@csr.com \
--cc=workgroup.linux@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox