* [PATCH] (resend) echoaudio disable device
@ 2005-05-11 20:36 Giuliano Pochini
2005-05-12 9:05 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Giuliano Pochini @ 2005-05-11 20:36 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Alsa-devel
*sigh*
- Add missing calls to pci_disable_device()
Signed-off-by: Giuliano Pochini <pochini@shiny.it>
diff -du alsa-driver__orig/pci/echoaudio/echoaudio.c alsa-driver/pci/echoaudio/echoaudio.c
--- alsa-driver__orig/pci/echoaudio/echoaudio.c Sat Apr 23 12:28:27 2005
+++ alsa-driver/pci/echoaudio/echoaudio.c Mon May 2 21:05:52 2005
@@ -1746,6 +1746,8 @@
}
DE_INIT(("MMIO freed.\n"));
+ pci_disable_device(chip->pci);
+
/* release chip data */
kfree(chip);
DE_INIT(("Chip freed.\n"));
@@ -1784,8 +1786,10 @@
/* allocate a chip-specific data */
chip = kcalloc(1, sizeof(echoaudio_t), GFP_KERNEL);
- if (!chip)
+ if (!chip) {
+ pci_disable_device(pci);
return -ENOMEM;
+ }
DE_INIT(("chip=%p\n", chip));
spin_lock_init(&chip->lock);
--
Giuliano.
-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7393&alloc_id=16281&op=click
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] (resend) echoaudio disable device
2005-05-11 20:36 [PATCH] (resend) echoaudio disable device Giuliano Pochini
@ 2005-05-12 9:05 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2005-05-12 9:05 UTC (permalink / raw)
To: Giuliano Pochini; +Cc: Alsa-devel
At Wed, 11 May 2005 22:36:01 +0200,
Giuliano Pochini wrote:
>
>
> *sigh*
>
> - Add missing calls to pci_disable_device()
>
>
> Signed-off-by: Giuliano Pochini <pochini@shiny.it>
Thanks, applied now. (sorry for the delay - I've been in vacation)
Takashi
-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7393&alloc_id=16281&op=click
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-05-12 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-11 20:36 [PATCH] (resend) echoaudio disable device Giuliano Pochini
2005-05-12 9:05 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox