From: Takashi Iwai <tiwai@suse.de>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH] ALSA: hda: Use standard waitqueue for RIRB wakeup
Date: Thu, 12 Dec 2019 19:42:48 +0100 [thread overview]
Message-ID: <s5hr21975cn.wl-tiwai@suse.de> (raw)
In-Reply-To: <s5hh825fog3.wl-tiwai@suse.de>
On Thu, 12 Dec 2019 18:23:08 +0100,
Takashi Iwai wrote:
>
> On Thu, 12 Dec 2019 18:17:14 +0100,
> Kai Vehmanen wrote:
> >
> > Hey,
> >
> > On Tue, 10 Dec 2019, Takashi Iwai wrote:
> >
> > > This patch attempts to improve the situation by introducing the
> > > standard waitqueue in the RIRB waiter side instead of polling. The
> >
> > this seems like a good change. It's a bit unfortunate this logic is not
> > yet shared and SOF uses the variant in snd_hdac_bus_get_response() -- that
> > would need similar treatment. I can make a matching change there and see
> > how this fairs in SOF CI. But basic tests with snd-hda-intel on a few
> > systems didn't reveal anything odd and code seems correct.
>
> Yes, please, the adaption to SOF is really appreciated.
> This is a 5.6 material and I applied only the changes I could actually
> test as a start.
And now I realized that adapting this for the common code is trivial,
and it's a good chance to unify the code there. I'll submit a test
patch set soon later. Stay tuned.
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-12-12 18:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 14:57 [alsa-devel] [PATCH] ALSA: hda: Use standard waitqueue for RIRB wakeup Takashi Iwai
2019-12-12 17:17 ` Kai Vehmanen
2019-12-12 17:23 ` Takashi Iwai
2019-12-12 18:42 ` Takashi Iwai [this message]
2019-12-13 13:05 ` Kai Vehmanen
2019-12-13 13:34 ` Takashi Iwai
2019-12-13 13:42 ` Takashi Iwai
2019-12-18 14:17 ` Jon Hunter
2019-12-18 14:31 ` Takashi Iwai
2019-12-19 12:15 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hr21975cn.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kai.vehmanen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox