From: Takashi Iwai <tiwai@suse.de>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: alsa-devel@alsa-project.org, kernel@avr32linux.org,
Hans-Christian Egtvedt <hcegtvedt@atmel.com>
Subject: Re: [PATCH 2/2] ALSA sound driver for the AT73C213 DAC using Atmel SSC driver
Date: Mon, 16 Jul 2007 17:32:52 +0200 [thread overview]
Message-ID: <s5hr6n8xt23.wl%tiwai@suse.de> (raw)
In-Reply-To: <20070716172746.777afe0e@dhcp-255-175.norway.atmel.com>
At Mon, 16 Jul 2007 17:27:46 +0200,
Haavard Skinnemoen wrote:
>
> On Mon, 16 Jul 2007 17:08:02 +0200
> Takashi Iwai <tiwai@suse.de> wrote:
>
> > > +struct at73c213_board_info {
> > > + int ssc_id;
> > > + struct clk *dac_clk;
> > > + char shortname[32];
> > > +};
> > > +
> > > +#endif /* __LINUX_SPI_AT73C213_H */
> >
> > Any reason to put this into include/linux? Are (or will be) there
> > users of this except for ALSA driver?
>
> This struct contains information about how the sound chip is hooked up
> on the board, so it needs to be defined in a place where the platform
> code can easily find it. Since it's not arch specific, it doesn't
> belong under <asm/...> so <linux/spi/...> seems like a logical choice.
>
> This patch shows how it's meant to be used:
>
> http://avr32linux.org/archives/kernel/2007-July/000124.html
Fair enough, then I have no objection about that.
Takashi
next prev parent reply other threads:[~2007-07-16 15:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 14:14 [PATCH 1/2] Add SPI devices to ALSA Kconfig and Makefile Hans-Christian Egtvedt
2007-07-16 14:14 ` [PATCH 2/2] ALSA sound driver for the AT73C213 DAC using Atmel SSC driver Hans-Christian Egtvedt
2007-07-16 14:15 ` Takashi Iwai
2007-07-16 14:25 ` Hans-Christian Egtvedt
2007-07-16 14:30 ` Takashi Iwai
2007-07-16 14:39 ` Takashi Iwai
2007-07-16 14:46 ` Hans-Christian Egtvedt
2007-07-16 14:47 ` Takashi Iwai
2007-07-16 14:43 ` Hans-Christian Egtvedt
2007-07-16 14:48 ` Takashi Iwai
2007-07-16 15:08 ` Takashi Iwai
2007-07-16 15:27 ` Haavard Skinnemoen
2007-07-16 15:32 ` Takashi Iwai [this message]
2007-07-17 8:37 ` Hans-Christian Egtvedt
2007-07-17 8:48 ` Haavard Skinnemoen
2007-07-17 8:54 ` Hans-Christian Egtvedt
2007-07-17 10:23 ` Takashi Iwai
2007-07-17 11:23 ` Hans-Christian Egtvedt
2007-07-17 11:36 ` Haavard Skinnemoen
2007-07-23 14:49 ` Takashi Iwai
2007-07-26 6:21 ` Hans-Christian Egtvedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hr6n8xt23.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=hcegtvedt@atmel.com \
--cc=hskinnemoen@atmel.com \
--cc=kernel@avr32linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox