From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ALSA: usb/line6: remove 'defined but not used' warning
Date: Wed, 08 Jul 2020 09:14:25 +0200 [thread overview]
Message-ID: <s5hsge2bhri.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200707184924.96291-1-pierre-louis.bossart@linux.intel.com>
On Tue, 07 Jul 2020 20:49:24 +0200,
Pierre-Louis Bossart wrote:
>
> Fix W=1 warning. Variables are declared in a header file included from
> multiple C files, replace by #defines as suggested by Takashi
>
> sound/usb/line6/driver.h:70:18: warning: ‘SYSEX_EXTRA_SIZE’ defined
> but not used [-Wunused-const-variable=]
> 70 | static const int SYSEX_EXTRA_SIZE = sizeof(line6_midi_id) + 4;
> | ^~~~~~~~~~~~~~~~
> sound/usb/line6/driver.h:69:18: warning: ‘SYSEX_DATA_OFS’ defined but
> not used [-Wunused-const-variable=]
> 69 | static const int SYSEX_DATA_OFS = sizeof(line6_midi_id) + 3;
> | ^~~~~~~~~~~~~~
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Applied, thanks.
Takashi
prev parent reply other threads:[~2020-07-08 7:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 18:49 [PATCH v2] ALSA: usb/line6: remove 'defined but not used' warning Pierre-Louis Bossart
2020-07-08 7:14 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsge2bhri.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox