* [PATCH v2] ALSA: usb/line6: remove 'defined but not used' warning
@ 2020-07-07 18:49 Pierre-Louis Bossart
2020-07-08 7:14 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-07 18:49 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai, Pierre-Louis Bossart
Fix W=1 warning. Variables are declared in a header file included from
multiple C files, replace by #defines as suggested by Takashi
sound/usb/line6/driver.h:70:18: warning: ‘SYSEX_EXTRA_SIZE’ defined
but not used [-Wunused-const-variable=]
70 | static const int SYSEX_EXTRA_SIZE = sizeof(line6_midi_id) + 4;
| ^~~~~~~~~~~~~~~~
sound/usb/line6/driver.h:69:18: warning: ‘SYSEX_DATA_OFS’ defined but
not used [-Wunused-const-variable=]
69 | static const int SYSEX_DATA_OFS = sizeof(line6_midi_id) + 3;
| ^~~~~~~~~~~~~~
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/usb/line6/driver.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/usb/line6/driver.h b/sound/usb/line6/driver.h
index 1a4e3700c80c..ec20fbec6475 100644
--- a/sound/usb/line6/driver.h
+++ b/sound/usb/line6/driver.h
@@ -66,8 +66,8 @@
extern const unsigned char line6_midi_id[3];
-static const int SYSEX_DATA_OFS = sizeof(line6_midi_id) + 3;
-static const int SYSEX_EXTRA_SIZE = sizeof(line6_midi_id) + 4;
+#define SYSEX_DATA_OFS (sizeof(line6_midi_id) + 3)
+#define SYSEX_EXTRA_SIZE (sizeof(line6_midi_id) + 4)
/*
Common properties of Line 6 devices.
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ALSA: usb/line6: remove 'defined but not used' warning
2020-07-07 18:49 [PATCH v2] ALSA: usb/line6: remove 'defined but not used' warning Pierre-Louis Bossart
@ 2020-07-08 7:14 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2020-07-08 7:14 UTC (permalink / raw)
To: Pierre-Louis Bossart; +Cc: alsa-devel
On Tue, 07 Jul 2020 20:49:24 +0200,
Pierre-Louis Bossart wrote:
>
> Fix W=1 warning. Variables are declared in a header file included from
> multiple C files, replace by #defines as suggested by Takashi
>
> sound/usb/line6/driver.h:70:18: warning: ‘SYSEX_EXTRA_SIZE’ defined
> but not used [-Wunused-const-variable=]
> 70 | static const int SYSEX_EXTRA_SIZE = sizeof(line6_midi_id) + 4;
> | ^~~~~~~~~~~~~~~~
> sound/usb/line6/driver.h:69:18: warning: ‘SYSEX_DATA_OFS’ defined but
> not used [-Wunused-const-variable=]
> 69 | static const int SYSEX_DATA_OFS = sizeof(line6_midi_id) + 3;
> | ^~~~~~~~~~~~~~
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-08 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-07 18:49 [PATCH v2] ALSA: usb/line6: remove 'defined but not used' warning Pierre-Louis Bossart
2020-07-08 7:14 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox