From: Takashi Iwai <tiwai@suse.de>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: alsa-devel@alsa-project.org, Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH] HDMI - fix ELD monitor name length
Date: Wed, 29 Jun 2011 08:50:57 +0200 [thread overview]
Message-ID: <s5hsjqtruzy.wl%tiwai@suse.de> (raw)
In-Reply-To: <20110629062607.GA17342@localhost>
At Wed, 29 Jun 2011 14:26:07 +0800,
Wu Fengguang wrote:
>
> I noticed that the last character of the ELD monitor name is lost,
> this fixes the issue.
>
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Thanks, applied now (with more changelog comments from your follow-up
mail).
Takashi
> ---
> sound/pci/hda/hda_eld.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- sound-2.6.orig/sound/pci/hda/hda_eld.c 2011-06-29 13:08:23.000000000 +0800
> +++ sound-2.6/sound/pci/hda/hda_eld.c 2011-06-29 14:13:25.000000000 +0800
> @@ -294,7 +294,7 @@ static int hdmi_update_eld(struct hdmi_e
> snd_printd(KERN_INFO "HDMI: out of range MNL %d\n", mnl);
> goto out_fail;
> } else
> - strlcpy(e->monitor_name, buf + ELD_FIXED_BYTES, mnl);
> + strlcpy(e->monitor_name, buf + ELD_FIXED_BYTES, mnl + 1);
>
> for (i = 0; i < e->sad_count; i++) {
> if (ELD_FIXED_BYTES + mnl + 3 * (i + 1) > size) {
>
prev parent reply other threads:[~2011-06-29 6:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 6:26 [PATCH] HDMI - fix ELD monitor name length Wu Fengguang
2011-06-29 6:31 ` Wu Fengguang
2011-06-29 6:50 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsjqtruzy.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=fengguang.wu@intel.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox