Re: [PATCH 0/3] pcm_file report EIO when fail to write to debug file

[Takashi Iwai <tiwai@suse.de>]

On Mon, 01 Jul 2019 15:25:15 +0200,
Adam Miartus wrote:
> 
> Previously, I introduced a patch that may return EPIPE error when pcm_file
> plugin fails to write to output file for some reason.
> 
> The purpose of reporting the error was to evade assert in code to allow
> API user error handling and recovery, or more clarity in debugging.
> 
> Failing to write to a file usually means bad file descriptor, running
> out of free memory, insufficient file permissions or in case file
> is a pipe there may be other reasons preventing the write operation.
> All these are not easily recoverable by restaring playback as EPIPE
> error which is used to signal XRUN might suggest. Therefore, use EIO
> to signal a different kind of error.
> 
> write_wav_header function is refactored a bit for more detailed
> error handling in case of failed write operation.
> 
> Adam Miartus (3):
>   pcm_file: use EIO instead of EPIPE when failing to write output file
>   pcm_file: improve error checking in write_wav_header function
>   pcm_file: in case of failed write clear file buffer variables

I applied patches 1 and 3.  Could you resubmit patch 2 after
correction?


thanks,

Takashi