From: Takashi Iwai <tiwai@suse.de>
To: Adam Miartus <amiartus@de.adit-jv.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/3] pcm_file: use EIO instead of EPIPE when failing to write output file
Date: Wed, 03 Jul 2019 14:23:22 +0200 [thread overview]
Message-ID: <s5hwogz2tol.wl-tiwai@suse.de> (raw)
In-Reply-To: <1561987518-2828-2-git-send-email-amiartus@de.adit-jv.com>
On Mon, 01 Jul 2019 15:25:16 +0200,
Adam Miartus wrote:
>
> EPIPE is defined as XRUN which is not entirely correct in this condition
>
> failing to write to a file in pcm_file plugin can not be simply recovered
> by a retry as user of the api might be led to believe when receiving EPIPE
>
> use EIO instead to indicate a different kid of error that may not be
> recoverable by retry
>
> Signed-off-by: Adam Miartus <amiartus@de.adit-jv.com>
> Reviewed-by: Timo Wischer <twischer@de.adit-jv.com>
Applied, thanks.
Takashi
next prev parent reply other threads:[~2019-07-03 12:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 13:25 [PATCH 0/3] pcm_file report EIO when fail to write to debug file Adam Miartus
2019-07-01 13:25 ` [PATCH 1/3] pcm_file: use EIO instead of EPIPE when failing to write output file Adam Miartus
2019-07-03 12:23 ` Takashi Iwai [this message]
2019-07-01 13:25 ` [PATCH 2/3] pcm_file: improve error checking in write_wav_header function Adam Miartus
2019-07-03 12:21 ` Takashi Iwai
2019-07-01 13:25 ` [PATCH 3/3] pcm_file: in case of failed write clear file buffer variables Adam Miartus
2019-07-03 12:23 ` Takashi Iwai
2019-07-03 12:23 ` [PATCH 0/3] pcm_file report EIO when fail to write to debug file Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwogz2tol.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=amiartus@de.adit-jv.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox