Fix ALC233 default init

Fix ALC233 default init

[Kailang]

[-- Attachment #1: Type: text/plain, Size: 84 bytes --]

Hi Takashi,
 
Attach patch was for fix ALC233 for default initial.

BR,
Kailang

[-- Attachment #2: 0000-alc233-additional-support.patch --]
[-- Type: application/octet-stream, Size: 1057 bytes --]

From b21106f83613fbe55d46241642352d897b9c1cf8 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Wed, 25 Apr 2018 15:31:52 +0800
Subject: [PATCH] ALSA: hda/realtek - Add some fixes for ALC233

Fill COEF to change EAPD to verb control.
Assigned codec type.

Additional: 92f974df346013160481324c39851e7ea9ce482a ("ALSA: hda/realtek - New vendor ID for ALC233")
Signed-off-by: Kailang Yang <kailang@realtek.com>

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index c0c4043..2086949 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -331,6 +331,7 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
 		/* fallthrough */
 	case 0x10ec0215:
 	case 0x10ec0233:
+	case 0x10ec0235:
 	case 0x10ec0236:
 	case 0x10ec0255:
 	case 0x10ec0256:
@@ -7160,6 +7161,7 @@ static int patch_alc269(struct hda_codec *codec)
 	case 0x10ec0298:
 		spec->codec_variant = ALC269_TYPE_ALC298;
 		break;
+	case 0x10ec0235:
 	case 0x10ec0255:
 		spec->codec_variant = ALC269_TYPE_ALC255;
 		break;

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: Fix ALC233 default init

[Takashi Iwai]

On Wed, 25 Apr 2018 09:56:28 +0200,
Kailang wrote:
> 
> Hi Takashi,
>  
> Attach patch was for fix ALC233 for default initial.

So this changes the initial coef to be equivalent with ALC255?
What about alc_process_coef_fw() for headset?

Anyways, a bit more details would be helpful.


thanks,

Takashi

> 
> BR,
> Kailang
> [2 0000-alc233-additional-support.patch <application/octet-stream (base64)>]
> 

Re: Fix ALC233 default init

[Kailang]

 

> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai@suse.de] 
> Sent: Wednesday, April 25, 2018 4:04 PM
> To: Kailang
> Cc: (alsa-devel@alsa-project.org)
> Subject: Re: Fix ALC233 default init
> 
> On Wed, 25 Apr 2018 09:56:28 +0200,
> Kailang wrote:
> > 
> > Hi Takashi,
> >  
> > Attach patch was for fix ALC233 for default initial.
> 
> So this changes the initial coef to be equivalent with ALC255?
ID: 0x10ec0235 Bonding for ALC233
This codec equivalent with ALC255. It only use for Lenovo.

> What about alc_process_coef_fw() for headset?
Not need. Because this codec only for Lenovo.

> 
> Anyways, a bit more details would be helpful.
> 
> 
> thanks,
> 
> Takashi
> 
> > 
> > BR,
> > Kailang
> > [2 0000-alc233-additional-support.patch <application/octet-stream 
> > (base64)>]
> > 
> 
> ------Please consider the environment before printing this e-mail.
> 

Re: Fix ALC233 default init

[Takashi Iwai]

On Wed, 25 Apr 2018 10:15:51 +0200,
Kailang wrote:
> 
>  
> 
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai@suse.de] 
> > Sent: Wednesday, April 25, 2018 4:04 PM
> > To: Kailang
> > Cc: (alsa-devel@alsa-project.org)
> > Subject: Re: Fix ALC233 default init
> > 
> > On Wed, 25 Apr 2018 09:56:28 +0200,
> > Kailang wrote:
> > > 
> > > Hi Takashi,
> > >  
> > > Attach patch was for fix ALC233 for default initial.
> > 
> > So this changes the initial coef to be equivalent with ALC255?
> ID: 0x10ec0235 Bonding for ALC233
> This codec equivalent with ALC255. It only use for Lenovo.
> 
> > What about alc_process_coef_fw() for headset?
> Not need. Because this codec only for Lenovo.

OK, I applied the patch with a bit more notes.
Thanks.


Takashi