Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Fabian Frederick <fabf@skynet.be>
Cc: alsa-devel@alsa-project.org, Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH 1/1] sound/aoa/codecs/onyx.c: use static const	for texts
Date: Tue, 27 May 2014 12:01:03 +0200	[thread overview]
Message-ID: <s5htx8bilr4.wl%tiwai@suse.de> (raw)
In-Reply-To: <20140527091218.246af6a3346fa67930e41f18@skynet.be>

At Tue, 27 May 2014 09:12:18 +0200,
Fabian Frederick wrote:
> 
> 'texts' is only used as source in strcpy
> 
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiway@suse.de>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Thanks, applied.


Takashi

> ---
> This is untested.
> 
>  sound/aoa/codecs/onyx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c
> index f01bffb..401107b 100644
> --- a/sound/aoa/codecs/onyx.c
> +++ b/sound/aoa/codecs/onyx.c
> @@ -241,7 +241,7 @@ static struct snd_kcontrol_new inputgain_control = {
>  static int onyx_snd_capture_source_info(struct snd_kcontrol *kcontrol,
>  	struct snd_ctl_elem_info *uinfo)
>  {
> -	static char *texts[] = { "Line-In", "Microphone" };
> +	static const char * const texts[] = { "Line-In", "Microphone" };
>  
>  	uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
>  	uinfo->count = 1;
> -- 
> 1.9.1
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

      reply	other threads:[~2014-05-27 10:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-27  7:12 [PATCH 1/1] sound/aoa/codecs/onyx.c: use static const for texts Fabian Frederick
2014-05-27 10:01 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5htx8bilr4.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=fabf@skynet.be \
    --cc=johannes@sipsolutions.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox