Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: pavel@ucw.cz, alsa-devel@alsa-project.org,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: Re: [PATCH] ASoC: tlv320aic3x: Fix data delay configuration
Date: Fri, 30 Jan 2015 15:18:42 +0100	[thread overview]
Message-ID: <s5hvbjo73nh.wl-tiwai@suse.de> (raw)
In-Reply-To: <1422621751-30484-1-git-send-email-peter.ujfalusi@ti.com>

At Fri, 30 Jan 2015 14:42:31 +0200,
Peter Ujfalusi wrote:
> 
> Fix the issue introduced by:
> 368494093354 ASoC: tlv320aic3x: Add TDM support

Please put "Fixes:" tag in such a case.

I guess we'll have a chance to send the last pull request for 3.19 in
the next week.  If we miss it, we'll have to mark this with Cc to
stable.


Takashi

> 
> The CTRLC register were not receiving the correct delay configuration,
> which will corrupt DSP_A audio mode.
> 
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Hi,
> 
> most of my boards are using DSP_B or I2S mode... This is why this is slipped.
> 
> Peter
> 
>  sound/soc/codecs/tlv320aic3x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
> index a78ad361f494..07603d142923 100644
> --- a/sound/soc/codecs/tlv320aic3x.c
> +++ b/sound/soc/codecs/tlv320aic3x.c
> @@ -1046,7 +1046,7 @@ static int aic3x_prepare(struct snd_pcm_substream *substream,
>  		delay += aic3x->tdm_delay;
>  
>  	/* Configure data delay */
> -	snd_soc_write(codec, AIC3X_ASD_INTF_CTRLC, aic3x->tdm_delay);
> +	snd_soc_write(codec, AIC3X_ASD_INTF_CTRLC, delay);
>  
>  	return 0;
>  }
> -- 
> 2.2.2
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

      parent reply	other threads:[~2015-01-30 14:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30 12:42 [PATCH] ASoC: tlv320aic3x: Fix data delay configuration Peter Ujfalusi
2015-01-30 12:52 ` Pavel Machek
2015-01-30 17:50   ` Jarkko Nikula
2015-01-30 14:18 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hvbjo73nh.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=lgirdwood@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox