From: Takashi Iwai <tiwai@suse.de>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/9] ALSA: pcm_params: Remove unused add/sub functions
Date: Tue, 30 Dec 2014 16:49:17 +0100 [thread overview]
Message-ID: <s5hvbktgmte.wl-tiwai@suse.de> (raw)
In-Reply-To: <1419878506-28684-1-git-send-email-lars@metafoo.de>
At Mon, 29 Dec 2014 19:41:38 +0100,
Lars-Peter Clausen wrote:
>
> Those two functions are not used anywhere and also their name is a bit to
> generic to be in a global header, so remove them.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks, applied all 9 patches. But the patch 3 was applied to
for-linus branch for 3.19-rc, as it's an obvious fix. The rest are
targeted for 3.20.
Takashi
> ---
> include/sound/pcm_params.h | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/include/sound/pcm_params.h b/include/sound/pcm_params.h
> index 6b1c78f..15760f5 100644
> --- a/include/sound/pcm_params.h
> +++ b/include/sound/pcm_params.h
> @@ -325,20 +325,6 @@ static inline int snd_interval_eq(const struct snd_interval *i1, const struct sn
> i1->max == i2->max && i1->openmax == i2->openmax;
> }
>
> -static inline unsigned int add(unsigned int a, unsigned int b)
> -{
> - if (a >= UINT_MAX - b)
> - return UINT_MAX;
> - return a + b;
> -}
> -
> -static inline unsigned int sub(unsigned int a, unsigned int b)
> -{
> - if (a > b)
> - return a - b;
> - return 0;
> -}
> -
> #define params_access(p) ((__force snd_pcm_access_t)\
> snd_mask_min(hw_param_mask_c((p), SNDRV_PCM_HW_PARAM_ACCESS)))
> #define params_format(p) ((__force snd_pcm_format_t)\
> --
> 1.8.0
>
prev parent reply other threads:[~2014-12-30 15:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 18:41 [PATCH 1/9] ALSA: pcm_params: Remove unused add/sub functions Lars-Peter Clausen
2014-12-29 18:41 ` [PATCH 2/9] ALSA: pcm: Remove unused SNDRV_PCM_IOCTL1_{FALSE, TRUE} defines Lars-Peter Clausen
2014-12-29 18:41 ` [PATCH 3/9] ALSA: pcm: Fix kerneldoc for params_*() functions Lars-Peter Clausen
2014-12-29 18:41 ` [PATCH 4/9] ALSA: pcm: Convert params_* mask helpers to static inline functions Lars-Peter Clausen
2014-12-29 18:41 ` [PATCH 5/9] ALSA: pcm: Add kernel doc for params_*() functions Lars-Peter Clausen
2014-12-29 18:41 ` [PATCH 6/9] ALSA: pcm: Simplify params_period_bytes() Lars-Peter Clausen
2014-12-29 18:41 ` [PATCH 7/9] ALSA: pcm: Use __ffs() instead of ffs() in snd_mask_min() Lars-Peter Clausen
2014-12-29 18:41 ` [PATCH 8/9] ALSA: snd_pcm_oss_period_size: Use round{up, down}_pow_of_two() Lars-Peter Clausen
2014-12-29 18:41 ` [PATCH 9/9] ALSA: pcm: Replace custom ld2 function with __fls Lars-Peter Clausen
2014-12-30 15:49 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hvbktgmte.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox