Re: [PATCH 0/6] ALSA: firewire: simplify symbol space for local linkage

[Takashi Iwai <tiwai@suse.de>]

On Tue, 03 Jan 2017 13:41:15 +0100,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> This patchset is just for code improvements, without adding features.
> 
> Modules in ALSA firewire stack have some implementations for operation
> structures which sound subsystem defines. All of them are referred just by
> each local function to register corresponding operations. In this case, it's
> better to put them into the function local so that symbol space in local
> linkage of translation unit is kept to be simple.

Do we see any merit in the resultant binaries by these changes?
I'm not against this kind of code changes, but just wondered.
That is, it's not totally clear what you takes as really "better" in
your context.


thanks,

Takashi


> 
> Takashi Sakamoto (6):
>   ALSA: bebob: simplify symbol space for local linkage
>   ALSA: fireworks: simplify symbol space for local linkage
>   ALSA: oxfw: simplify symbol space for local linkage
>   ALSA: dice: simplify symbol space for local linkage
>   ALSA: firewire-digi00x: simplify symbol space for local linkage
>   ALSA: firewire-tascam: simplify symbol space for local linkage
> 
>  sound/firewire/bebob/bebob_hwdep.c         | 17 +++++-----
>  sound/firewire/bebob/bebob_midi.c          | 26 +++++++--------
>  sound/firewire/bebob/bebob_pcm.c           | 51 ++++++++++++++---------------
>  sound/firewire/dice/dice-midi.c            | 22 ++++++-------
>  sound/firewire/digi00x/digi00x-hwdep.c     | 17 +++++-----
>  sound/firewire/digi00x/digi00x-midi.c      | 52 ++++++++++++++----------------
>  sound/firewire/digi00x/digi00x-pcm.c       | 52 ++++++++++++++----------------
>  sound/firewire/fireworks/fireworks_hwdep.c | 19 ++++++-----
>  sound/firewire/fireworks/fireworks_midi.c  | 26 +++++++--------
>  sound/firewire/fireworks/fireworks_pcm.c   | 52 ++++++++++++++----------------
>  sound/firewire/oxfw/oxfw-midi.c            | 26 +++++++--------
>  sound/firewire/tascam/tascam-hwdep.c       | 17 +++++-----
>  sound/firewire/tascam/tascam-midi.c        | 26 +++++++--------
>  sound/firewire/tascam/tascam-pcm.c         | 52 ++++++++++++++----------------
>  14 files changed, 215 insertions(+), 240 deletions(-)
> 
> -- 
> 2.9.3
>