Re: [PATCH 0/6] ALSA: firewire: simplify symbol space for local linkage

[Takashi Iwai <tiwai@suse.de>]

On Wed, 04 Jan 2017 11:36:10 +0100,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On Jan 4 2016 03:43, Takashi Iwai wrote:
> > On Tue, 03 Jan 2017 13:41:15 +0100,
> > Takashi Sakamoto wrote:
> >>
> >> Hi,
> >>
> >> This patchset is just for code improvements, without adding features.
> >>
> >> Modules in ALSA firewire stack have some implementations for operation
> >> structures which sound subsystem defines. All of them are referred just by
> >> each local function to register corresponding operations. In this case, it's
> >> better to put them into the function local so that symbol space in local
> >> linkage of translation unit is kept to be simple.
> >
> > Do we see any merit in the resultant binaries by these changes?
> > I'm not against this kind of code changes, but just wondered.
> > That is, it's not totally clear what you takes as really "better" in
> > your context.
> 
> Mmm, sorry but my explanation is wrong. I managed to describe the
> reason in an aspect of local linkage, but an aim of this patchset is
> irrelevant to it.
> 
> The aim is for identifier space of each translation unit. The merit
> can be described in two points:
>  - For readers
>   - readers have no concern about where the identifier is referred.
>     It's just inner the including function.
>  - For identifier space of the file
>   - developers are free from name conflict for further work.
> 
> If no objections against the aim, I'll resubmit this patchset with
> proper commit comments.

Yes, please go ahead.


thanks,

Takashi