From: Takashi Iwai <tiwai@suse.de>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: "Li, Zhen-Hua" <zhen-hual@hp.com>,
Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] driver/snd: es18xx driver should use udelay error
Date: Mon, 14 Apr 2014 14:30:17 +0200 [thread overview]
Message-ID: <s5hwqesm6ue.wl%tiwai@suse.de> (raw)
In-Reply-To: <534BCDE8.1090202@ladisch.de>
At Mon, 14 Apr 2014 14:00:40 +0200,
Clemens Ladisch wrote:
>
> Li, Zhen-Hua wrote:
> > udelay with more than 20000 may cause __bad_udelay.
> > Use mdelay for instead.
> >
> > #ifdef AVOID_POPS
> > /* Avoid pops */
> > - udelay(100000);
> > + mudelay(100);
>
> This will not compile. Please test with AVOID_POPS enabled.
Oops, thanks for spotting. I fixed it now.
Takashi
next prev parent reply other threads:[~2014-04-14 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 9:43 [PATCH 1/1] driver/snd: es18xx driver should use udelay error Li, Zhen-Hua
2014-04-14 12:00 ` Clemens Ladisch
2014-04-14 12:30 ` Takashi Iwai [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-14 9:41 Li, Zhen-Hua
2014-04-14 9:46 ` Takashi Iwai
2014-04-14 10:10 ` Li, ZhenHua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwqesm6ue.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=zhen-hual@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox