From: Takashi Iwai <tiwai@suse.de>
To: Adam Miartus <amiartus@de.adit-jv.com>
Cc: alsa-devel@alsa-project.org, Andreas Pape <apape@de.adit-jv.com>
Subject: Re: [ALSA patch] [PATCH 1/2] alsa: pcm: add unsupported OPS
Date: Tue, 09 Jul 2019 14:25:00 +0200 [thread overview]
Message-ID: <s5hy317tmxv.wl-tiwai@suse.de> (raw)
In-Reply-To: <1562583889-2109-2-git-send-email-amiartus@de.adit-jv.com>
On Mon, 08 Jul 2019 13:04:48 +0200,
Adam Miartus wrote:
>
> From: Andreas Pape <apape@de.adit-jv.com>
>
> Signed-off-by: Andreas Pape <apape@de.adit-jv.com>
> Signed-off-by: Adam Miartus <amiartus@de.adit-jv.com>
No description isn't good at all. There must be something you can
explain in details here.
About the changes:
> +#define PCM_UNSUPPORTED_ERR (-ENOSYS)
> +void snd_pcm_unsupported_dump(snd_pcm_t *pcm, snd_output_t *out)
> +{
> + snd_output_printf(out, "unsupported\n");
> +}
IMO, we don't need to show anything if it's dummy.
And, maybe it's more straightforward to let the PCM core allow NULL
ops?
thanks,
Takashi
next prev parent reply other threads:[~2019-07-09 12:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 11:04 [PATCH 0/2] expand dshare to allow audio clock when not streaming data Adam Miartus
2019-07-08 11:04 ` [PATCH 1/2] alsa: pcm: add unsupported OPS Adam Miartus
2019-07-09 12:25 ` Takashi Iwai [this message]
2019-07-10 14:58 ` [ALSA patch] " Miartus, Adam (Arion Recruitment; ADITG/ESM)
2019-07-10 14:59 ` Takashi Iwai
2019-07-11 14:58 ` Miartus, Adam (Arion Recruitment; ADITG/ESM)
2019-07-16 5:53 ` Takashi Iwai
2019-07-08 11:04 ` [PATCH 2/2] alsa: dshare: allow missing bindings Adam Miartus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hy317tmxv.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=amiartus@de.adit-jv.com \
--cc=apape@de.adit-jv.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox