From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, patches.audio@intel.com,
liam.r.girdwood@linux.intel.com, broonie@kernel.org,
Jeeja KP <jeeja.kp@intel.com>,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Subject: Re: [PATCH v3 4/7] ASoC: intel - add Skylake HDA platform driver
Date: Wed, 29 Apr 2015 14:31:02 +0200 [thread overview]
Message-ID: <s5hy4lbf75l.wl-tiwai@suse.de> (raw)
In-Reply-To: <1430250870-3169-5-git-send-email-vinod.koul@intel.com>
At Wed, 29 Apr 2015 01:24:27 +0530,
Vinod Koul wrote:
>
> +static struct snd_soc_dai_driver soc_hda_platform_dai[] = {
> +{
> + .name = "System Pin",
> + .ops = &hda_pcm_dai_ops,
> + .playback = {
> + .stream_name = "System Playback",
> + .channels_min = HDA_MONO,
> + .channels_max = HDA_STEREO,
> + .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_8000,
> + .formats = SNDRV_PCM_FMTBIT_S16_LE,
> + },
> + .capture = {
> + .stream_name = "System Capture",
> + .channels_min = HDA_MONO,
> + .channels_max = HDA_STEREO,
> + .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_16000,
> + .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE,
Is it really S24_LE? It's packed in lower 3 bytes of 4 bytes format.
> + },
> +},
> +{
> + .name = "Deepbuffer Pin",
> + .ops = &hda_pcm_dai_ops,
> + .playback = {
> + .stream_name = "Deepbuffer Playback",
> + .channels_min = HDA_STEREO,
> + .channels_max = HDA_STEREO,
> + .rates = SNDRV_PCM_RATE_48000,
> + .formats = SNDRV_PCM_FMTBIT_S16_LE,
> + },
> +},
> +{
> + .name = "LowLatency Pin",
> + .ops = &hda_pcm_dai_ops,
> + .playback = {
> + .stream_name = "Low Latency Playback",
> + .channels_min = HDA_STEREO,
> + .channels_max = HDA_STEREO,
> + .rates = SNDRV_PCM_RATE_48000,
> + .formats = SNDRV_PCM_FMTBIT_S16_LE,
> + },
Are there no S32_LE support at all for all dais?
Takashi
next prev parent reply other threads:[~2015-04-29 12:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 19:54 [PATCH v3 0/7] ASoC: intel - add skylake PCM driver Vinod Koul
2015-04-28 19:54 ` [PATCH v3 1/7] ASoC: hda - add soc hda codec driver wrapper Vinod Koul
2015-04-29 11:59 ` Takashi Iwai
2015-05-04 13:12 ` Mark Brown
2015-05-06 3:47 ` Vinod Koul
2015-05-06 12:51 ` Mark Brown
2015-05-06 16:51 ` Vinod Koul
2015-04-28 19:54 ` [PATCH v3 2/7] ALSA: hda - add new HDA registers Vinod Koul
2015-04-29 10:41 ` Takashi Iwai
2015-04-29 10:57 ` Vinod Koul
2015-04-29 12:02 ` Takashi Iwai
2015-04-28 19:54 ` [PATCH v3 3/7] ASoC: hda - adds SoC controller and stream operations Vinod Koul
2015-04-29 12:26 ` Takashi Iwai
2015-04-30 9:35 ` Vinod Koul
2015-04-30 9:49 ` Takashi Iwai
2015-04-28 19:54 ` [PATCH v3 4/7] ASoC: intel - add Skylake HDA platform driver Vinod Koul
2015-04-29 12:31 ` Takashi Iwai [this message]
2015-04-30 9:42 ` Vinod Koul
2015-04-30 9:52 ` Takashi Iwai
2015-04-30 10:39 ` Vinod Koul
2015-04-28 19:54 ` [PATCH v3 5/7] ASoC: intel - add Skylake HDA audio driver Vinod Koul
2015-04-29 12:49 ` Takashi Iwai
2015-04-30 10:11 ` Vinod Koul
2015-04-30 10:18 ` Takashi Iwai
2015-04-28 19:54 ` [PATCH v3 6/7] ASoC: intel - add makefile support for SKL driver Vinod Koul
2015-04-28 19:54 ` [PATCH v3 7/7] ASoC: intel - adds support for decoupled mode in skl driver Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hy4lbf75l.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox