Re: [PATCH - ca0106 1/6] ALSA: ca0106 - add Sound Blaster 5.1vx info.

[Takashi Iwai <tiwai@suse.de>]

At Thu, 21 Oct 2010 23:39:19 +1100,
Andy Owen wrote:
> 
> 
> Signed-off-by: Andy Owen <andy-alsa@ultra-premium.com>

Thanks for patches.
All changes look good in your patches, but could you give more
changelog for clarifying a bit more details what the patch is
actually for?

For example, I wondered why the patch 4 was necessary, and first
after looking at the next patch, I understood its necessity.
If it's written in the changelog that it's a preliminary work,
it'd be helpful for better understanding.


thanks,

Takashi

> diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c
> index 8e69620..6dc9a5d 100644
> --- a/sound/pci/ca0106/ca0106_main.c
> +++ b/sound/pci/ca0106/ca0106_main.c
> @@ -239,6 +239,16 @@ static struct snd_ca0106_details ca0106_chip_details[] = {
>  	   .gpio_type = 1,
>  	   .i2c_adc = 1,
>  	   .spi_dac = 1 } ,
> +	/* Sound Blaster 5.1vx
> +	 * Tested: Playback on front, rear, center/lfe speakers
> +	 * Not-Tested: Capture
> +	 */
> +	{ .serial = 0x10041102,
> +	  .name   = "Sound Blaster 5.1vx [SB1070]",
> +	  .gpio_type = 1,
> +	  .i2c_adc = 0,
> +	  .spi_dac = 1
> +	 } ,
>  	 /* MSI K8N Diamond Motherboard with onboard SB Live 24bit without AC97 */
>  	 /* SB0438
>  	  * CTRL:CA0106-DAT
> -- 
> 1.7.3.1.127.g1bb28
>