From: Takashi Iwai <tiwai@suse.de>
To: renidragsemaj@yahoo.com
Cc: alsa-devel@alsa-project.org
Subject: Re: [ALSA - patch_sigmatel.c for HP dv4-1222nr laptop 9/9Patch to patch_sigmatel.c for HP dv4-1222nr laptop
Date: Fri, 17 Apr 2009 08:59:39 +0200 [thread overview]
Message-ID: <s5hzlefahpg.wl%tiwai@suse.de> (raw)
In-Reply-To: <730476.70849.qm@web54507.mail.re2.yahoo.com>
At Thu, 16 Apr 2009 22:39:35 -0700 (PDT),
James Gardiner wrote:
>
>
>
>
>
> --- On Tue, 4/14/09, Takashi Iwai <tiwai@suse.de> wrote:
>
> >
> > Thanks for the patch. The change looks almost good to me.
> > See some comments below
> >
> >
> >
> > > + spec->num_dmics = 1;
> > > + spec->num_dmuxes = 2;
> > > + stac92xx_auto_set_pinctl(codec, 0x1c, 2);
> >
> > The number "2" doesn't look cute...
> >
> > Could you fix and repost the patch?
> >
> >
> > thanks,
> >
> > Takashi
>
> Are you worried it looks like a magic number? Or am I supposed to be
> looking for something else? Or would a '#define' be more what
> you're talking about?
Use constants defined in hda_codec.h.
For pin-setup, AC_PINCTL_* can be used.
> Can you (simple) explain to me what the PCI_QUIRK stuff does?
The driver identifies the specific model via PCI SSID (not codec
SSID). Check "lspci -nv" output and pass the value there.
thanks,
Takashi
prev parent reply other threads:[~2009-04-17 6:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 22:04 [ALSA - patch_sigmatel.c for HP dv4-1222nr laptop 9/9Patch to patch_sigmatel.c for HP dv4-1222nr laptop renidragsemaj
2009-04-14 13:10 ` Takashi Iwai
2009-04-17 5:39 ` James Gardiner
2009-04-17 6:59 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzlefahpg.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=renidragsemaj@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox