Re: [PATCH] drm/amdgpu/soc15: skip reset on init

From: "Lin, Amber" <Amber.Lin-5C7GfCeVMHo@public.gmane.org>
To: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu/soc15: skip reset on init
Date: Fri, 17 May 2019 19:15:47 +0000	[thread overview]
Message-ID: <017cfa62-2ccf-6605-e4ba-99768208103d@amd.com> (raw)
In-Reply-To: <CADnq5_PKFA62OMa4H9gKy4R9rk38mY0EKhZGxf51N36DkTEavQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Acked-by: Amber Lin <Amber.Lin@amd.com>

On 2019-05-17 1:02 p.m., Alex Deucher wrote:
> [CAUTION: External Email]
>
> On Fri, May 17, 2019 at 10:47 AM Lin, Amber <Amber.Lin@amd.com> wrote:
>>
>>
>> On 2019-05-17 10:26 a.m., Alex Deucher wrote:
>>> [CAUTION: External Email]
>>>
>>> Not necessary on soc15 and breaks driver reload on server cards.
>>>
>>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>>> Cc: stable@vger.kernel.org
>>> ---
>>>    drivers/gpu/drm/amd/amdgpu/soc15.c | 5 +++++
>>>    1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
>>> index 32dc5a128249..78bd4fc07bab 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/soc15.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
>>> @@ -761,6 +761,11 @@ static bool soc15_need_reset_on_init(struct amdgpu_device *adev)
>>>    {
>>>           u32 sol_reg;
>>>
>>> +       /* Just return false for soc15 GPUs.  Reset does not seem to
>>> +        * be necessary.
>>> +        */
>>> +       return false;
>>> +
>>>           if (adev->flags & AMD_IS_APU)
>>>                   return false;
>> Should remove the rest of code in this function and sol_reg as well?
>> Simply return false?
> I was thinking we'd leave it in place for now in case we need to
> re-enable it for something else in the future, but I guess we can just
> revert the change if need be.  I don't have a strong opinion either
> way.
>
> Alex
>
>>> --
>>> 2.20.1
>>>
>>> _______________________________________________
>>> amd-gfx mailing list
>>> amd-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx